[CDF-23755] 🤖 Robotics issue #1376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
doctrino
commented
Jan 17, 2025
Comment on lines
+7
to
+8
| modelId: {{ three_d_model_id }} | ||
| revisionId: {{ three_d_revision_id }} |
There was a problem hiding this comment.
This is what was causing the issue. The " causes modelId and revisionId to be read as string and not int. When trying to deploy it, the API will fail.
doctrino
commented
Jan 17, 2025
Comment on lines
+1
to
+5
| name: {{ three_d_model_name }} | ||
| externalId: {{ three_d_model_name }} | ||
| description: {{ three_d_type }} {{ three_d_model_name }} | ||
| mapType: {{ three_d_type }} | ||
| frameExternalId: frame_{{ three_d_model_name }} |
There was a problem hiding this comment.
I removed the rest of the " as well as they are not necessary.
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified FilesNo covered modified files...
|
ronpal
approved these changes
Jan 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Prefix the PR title with the Jira issue number on the form
[CDF-12345].Please describe the change you have made.
Checklist