Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CDF-23755] 🤖 Robotics issue #1376

Merged
merged 4 commits into from
Jan 20, 2025
Merged

[CDF-23755] 🤖 Robotics issue #1376

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
dab937d
fix: robotics template
doctrino Jan 17, 2025
6f3a24e
fix; robotics template
doctrino Jan 17, 2025
8eee1e6
build: changelog
doctrino Jan 17, 2025
da49356
Merge branch 'main' into robotics-issue
doctrino Jan 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions cognite_toolkit/_builtin_modules/inrobot/cdf_inrobot_location/robotics/root.Frame.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
- name: "Root frame at the origin of location {{ first_root_asset_external_id }}"
externalId: "{{ first_root_asset_external_id }}"
- name: "Frame {{ three_d_model_name }}"
externalId: "frame_{{ three_d_model_name }}"
- name: Root frame at the origin of location {{ first_root_asset_external_id }}
externalId: {{ first_root_asset_external_id }}
- name: Frame {{ three_d_model_name }}
externalId: frame_{{ three_d_model_name }}
transform:
parentFrameExternalId: "{{ first_root_asset_external_id }}"
parentFrameExternalId: {{ first_root_asset_external_id }}
translation:
x: 0.0
y: 0.0
Expand Down
4 changes: 2 additions & 2 deletions cognite_toolkit/_builtin_modules/inrobot/cdf_inrobot_location/robotics/root.Location.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
name: "{{ first_root_asset_external_id }}"
externalId: "{{ first_root_asset_external_id }}"
name: {{ first_root_asset_external_id }}
externalId: {{ first_root_asset_external_id }}
description: Robot location
14 changes: 7 additions & 7 deletions cognite_toolkit/_builtin_modules/inrobot/cdf_inrobot_location/robotics/root.Map.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
name: "{{ three_d_model_name }}"
externalId: "{{ three_d_model_name }}"
description: "{{ three_d_type }} {{ three_d_model_name }}"
mapType: "{{ three_d_type }}"
frameExternalId: "frame_{{ three_d_model_name }}"
name: {{ three_d_model_name }}
externalId: {{ three_d_model_name }}
description: {{ three_d_type }} {{ three_d_model_name }}
mapType: {{ three_d_type }}
frameExternalId: frame_{{ three_d_model_name }}
data:
Comment on lines +1 to +5
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed the rest of the " as well as they are not necessary.

modelId: "{{ three_d_model_id }}"
revisionId: "{{ three_d_revision_id }}"
modelId: {{ three_d_model_id }}
revisionId: {{ three_d_revision_id }}
locationExternalId: "{{ first_root_asset_external_id }}"
Comment on lines +7 to +8
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is what was causing the issue. The " causes modelId and revisionId to be read as string and not int. When trying to deploy it, the API will fail.

scale: 1.0
Loading