HKG: Car Port Hyundai Ioniq 5 PE (HDA2 & LFA2) #1676
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This update adds angle control functionality specifically for the Hyundai Ioniq 5 PE model. Changes were made across several files and variables to accommodate this additional feature. This control type provides enhanced handling and steering performance depending on the driving conditions, given its ability to adjust steering angle precisely. Angle control stems from the angle of the steering wheel rather than torque, providing a more sophisticated steering response. In the Hyundai Ioniq 5 PE, adjustments for the input angle and torque calculations have been added, ensuring a more dynamic and responsive driving experience. Variable additions include '`apply_angle_last`', '`lkas_max_torque`' and '`driver_applied_torque_reducer`', and a new condition was created for if the driver is manually applying some torque. All of these changes allow for the application of correct torque when the driver is not actively steering, emulating the behavior of a stock LKAS system when engaged.
devtekve
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update adds angle control functionality specifically for the Hyundai Ioniq 5 PE model. Changes were made across several files and variables to accommodate this additional feature. This control type provides enhanced handling and steering performance depending on the driving conditions, given its ability to adjust steering angle precisely.
Note1
The logic has really been built by @sunnyhaibin for #1674 which is still WIP as well, this is just a "clean" version for ioniq 5 PE
Note2
Do not test / use this yet, there's still work and safety validations that need to happen before it can be used