-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add bootupd, ostree and rpm-ostree repos & bootupd to release checklist #40
Conversation
66ed0e1
to
fad130f
Compare
|
||
files: | ||
- repo: afterburn | ||
path: .github/ISSUE_TEMPLATE/release-checklist.md | ||
vars: | ||
do_release_notes_doc: true | ||
|
||
- repo: bootupd | ||
path: .github/ISSUE_TEMPLATE/release-checklist.md |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will clobber the existing release checklist in that repo. I think the main consequence is that we'll need to remove ci/prepare-release.sh
, but there might be other things as well. Perhaps we should confirm this change with a repo maintainer before landing it here.
See: coreos#30
Those are weird cases where we have some rust but no crate.
ca4f872
to
d13248b
Compare
CC @cgwalters @lucab for the changes needed in bootupd release process. This does not enable rpm-ostree & ostree yet as their release process is slightly different. |
url: https://github.com/coreos/bootupd | ||
vars: | ||
git_repo: bootupd | ||
crate: bootupd |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't been updating this because there's no reason to.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The idea is to unify our procedures across our repos to make sure that if we do an emergency update, anybody on the team can do it safely following the instructions. This also reduces the chance of errors during releases.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah fair enough...it just feels silly to publish things to crates.io which one shouldn't actually use as a Rust dependency or cargo install
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm fine not doing that if that's not needed and we can tweak the release checklist. I appears that we're doing that right now from https://github.com/coreos/bootupd/blob/main/.github/ISSUE_TEMPLATE/release-checklist.md
Add bootupd
See: #30
config: Add ostree & rpm-ostree
Those are weird cases where we have some rust but no crate.
rust: Filter vendor tarball by default