Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bootupd, ostree and rpm-ostree repos & bootupd to release checklist #40

Closed
wants to merge 2 commits into from

Conversation

travier
Copy link
Member

@travier travier commented Sep 9, 2022

Add bootupd

See: #30


config: Add ostree & rpm-ostree

Those are weird cases where we have some rust but no crate.


rust: Filter vendor tarball by default

@travier travier force-pushed the rust branch 2 times, most recently from 66ed0e1 to fad130f Compare September 9, 2022 17:52
@travier travier changed the title Add bootupd, ostree and rpm-ostree Add bootupd, ostree and rpm-ostree repo & bootupd to release checklist Sep 9, 2022
@travier travier changed the title Add bootupd, ostree and rpm-ostree repo & bootupd to release checklist Add bootupd, ostree and rpm-ostree repos & bootupd to release checklist Sep 12, 2022

files:
- repo: afterburn
path: .github/ISSUE_TEMPLATE/release-checklist.md
vars:
do_release_notes_doc: true

- repo: bootupd
path: .github/ISSUE_TEMPLATE/release-checklist.md
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will clobber the existing release checklist in that repo. I think the main consequence is that we'll need to remove ci/prepare-release.sh, but there might be other things as well. Perhaps we should confirm this change with a repo maintainer before landing it here.

Those are weird cases where we have some rust but no crate.
@travier
Copy link
Member Author

travier commented Sep 14, 2022

CC @cgwalters @lucab for the changes needed in bootupd release process.

This does not enable rpm-ostree & ostree yet as their release process is slightly different.

url: https://github.com/coreos/bootupd
vars:
git_repo: bootupd
crate: bootupd
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't been updating this because there's no reason to.

Copy link
Member Author

@travier travier Sep 19, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The idea is to unify our procedures across our repos to make sure that if we do an emergency update, anybody on the team can do it safely following the instructions. This also reduces the chance of errors during releases.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah fair enough...it just feels silly to publish things to crates.io which one shouldn't actually use as a Rust dependency or cargo install.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine not doing that if that's not needed and we can tweak the release checklist. I appears that we're doing that right now from https://github.com/coreos/bootupd/blob/main/.github/ISSUE_TEMPLATE/release-checklist.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants