Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rust: Filter vendor tarball by default #42

Closed
wants to merge 1 commit into from

Conversation

travier
Copy link
Member

@travier travier commented Sep 14, 2022

We generally want to filter out non-Linux support from our vendor tarballs.

@travier
Copy link
Member Author

travier commented Sep 14, 2022

As Benjamin mentioned in #40 (comment), this needs changes in the following repos:

CC @lucab

@travier
Copy link
Member Author

travier commented Sep 14, 2022

And bootupd (added in #40).
CC @cgwalters

@bgilbert
Copy link
Contributor

ignition-config-rs and openssh-keys aren't affected because they're libraries and don't ship a vendor tarball.

We generally want to filter out non-Linux support from our vendor
tarballs.
@bgilbert
Copy link
Contributor

bgilbert commented Feb 3, 2023

I've opened PRs for the remaining projects. In principle we could get this in and let the individual projects merge the checklist updates when they're ready.

@bgilbert
Copy link
Contributor

bgilbert commented Feb 3, 2023

It turns out that find target/vendor -name '*.a' -delete isn't safe in general, since the rustix crate ships Linux-specific static archives. So I'd favor deleting the non-vendor-filterer case altogether.

@bgilbert
Copy link
Contributor

bgilbert commented Feb 4, 2023

I've done that in #84. Closing this PR in favor of that one.

@bgilbert bgilbert closed this Feb 4, 2023
@travier travier deleted the vendor-filtered branch February 8, 2023 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants