[Saved Courses] Add Icon to Sidebar #882
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[diff-counting] Significant lines: 683. |
|
Visit the preview URL for this PR (updated for commit b065939): https://cornelldti-courseplan-dev--pr882-andrew-saved-course-too77soj.web.app (expires Tue, 26 Nov 2024 19:56:37 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 6d4e0437c4559ed895272bbd63991394f1e0e933 |
Merged
added 3 commits
February 14, 2024 09:28
andxu282
force-pushed
the
andrew--saved-courses-icon
branch
from
62a4077 to
5b994a7
Compare
plumshum
reviewed
Mar 1, 2024
There was a problem hiding this comment.
Followed your videos and got the same results.
However, might be some inconsistencies when you resize the screen.
If I make the screen smaller so that the sidebar doesn't show up automatically, then I hit the dropdown menu, the saved courses icon doesn't show up. I don't know if we are intentionally not showing this icon, or that's not part of the PR.
Here is a video:
CoursePlan.-.Google.Chrome.2024-03-01.17-17-05.mp4
4 tasks
* added save-collection emit * create sidebar vue * connected dashboard and sidebar * finished empty front-end look * adjust hover * fixed positioning * update artifact version * added front-end look for saved courses in collection * fixed collectionsidebar css for frontend implementation * edit collection modal + front-end fixes - added edit collection modal and text input collection modal - fixed front-end with trash can - fixed front-end with dropdown button and edit collection button * frontend fixes - fixed padding - fixed null issue * added helper function in utilities
nidhi-mylavarapu
pushed a commit
that referenced
this pull request
Oct 30, 2024
* [Saved Courses] add save modal (#912) * Change course menu to click state (#898) * add save button and icon * change position of save course button * added new Save Course Modal * added new Save Course Modal * added basic front-end look * re-edit teleport modal * fixed basic front-end look * renamed icon * fixed frontend alignment * fixed frontend alignment and file path * added feature flag for save course modal * fixed front-end bug and modal hierachy * change method and emit names --------- Co-authored-by: KaylinChan <[email protected]> * added collections in store. add backend methods and gtags * added basic functionality for save course - can save a course when press 'done' - course is saved to an empty collection - add functions for add & edit collection * fixed functionality for save courses to mutliple collections - can save one course to multiple collections w/ checkbox - saved course will be removed from semester view and from fullfilled requirements - pop up notification * finished backend and fixed frontend - finished scrollable checkbox frontend - fixed the bug for selecting a singular checkbox - believed its stored in firestore when added to collection - renamed collection to savedCourses for firesetore clarity * created editabilify for collection names - saveCourseModal allow user to name their new collections - moved scss into a separate file * fixed backend error and logic - added updateDoc in backend functions - made edit Collections modal more functional with saveCourse * [Saved Courses] Add Icon to Sidebar (#882) * add icon * fix icon * feature flag * fixed feature flags * collections page empty front-end look (#940) * added save-collection emit * create sidebar vue * connected dashboard and sidebar * finished empty front-end look * adjust hover * fixed positioning * update artifact version * added front-end look for saved courses in collection * fixed collectionsidebar css for frontend implementation * edit collection modal + front-end fixes - added edit collection modal and text input collection modal - fixed front-end with trash can - fixed front-end with dropdown button and edit collection button * frontend fixes - fixed padding - fixed null issue * added helper function in utilities * ran prettier * frontend fixes --------- Co-authored-by: Hannah Zhou <[email protected]> Co-authored-by: Hannah Zhou <[email protected]> * merged sidebar with backend * fixed migration script and bottom course bar * feat: draggable saved courses * chore: prettify things * ran prettier and type check * fixed cu review api * fixed div * remove feature flag * frontend and type check fixes * resolved front-end issue with plans * fixed more front-end and confirmation modal * fixed frontend * ran prettier * last fix --------- Co-authored-by: KaylinChan <[email protected]> Co-authored-by: andrew xu <[email protected]> Co-authored-by: Simon Ilincev <[email protected]> Co-authored-by: Simon Ilincev <[email protected]>
Merged
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds the saved courses icon to the sidebar.
Remaining TODOs:
Depends on #{number of PR}
Test Plan
Screen.Recording.2024-02-13.at.7.28.09.PM.mov