Support ILR Econ Minor #959
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[diff-counting] Significant lines: 103. |
|
Visit the preview URL for this PR (updated for commit 001f94d): https://cornelldti-courseplan-dev--pr959-ilr-econ-minor-3ozz1l1i.web.app (expires Tue, 17 Dec 2024 21:47:59 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 6d4e0437c4559ed895272bbd63991394f1e0e933 |
plumshum
reviewed
Nov 15, 2024
| perSlotMinCount: [1, 1, 1], | ||
| slotNames: ['MATH 1110', 'ECON 1110', 'ECON 1120'], | ||
| checkerWarning: | ||
| 'ECON 1110 or ECON 1120 will count toward the Economics Minor only if credit for the course appears on your Cornell transcript.', |
There was a problem hiding this comment.
Aligned with the current rubric.
plumshum
reviewed
Nov 15, 2024
| { | ||
| name: 'Statistics and Econometrics', | ||
| description: | ||
| 'Option 1: ECON 3110 and ECON 3120. Option 2: ECON 3130 and ECON 3140. Must be taken at Cornell.', |
plumshum
reviewed
Nov 15, 2024
src/data/minors/econILR.ts
Outdated
| description: | ||
| 'Additional 3000 or 4000 level ECON courses to reach a total of 9 courses. ' + | ||
| 'ECON 4990, 4991, and 4999 cannot be counted. ' + | ||
| 'At least 5 of your 3000/4000-level courses must be taken at Cornell.', |
There was a problem hiding this comment.
The exception for this is for Study Abroad, in which you must take atleast 4 of them at Cornell.
plumshum
approved these changes
Nov 15, 2024
plumshum
reviewed
Nov 15, 2024
src/data/index.ts
Outdated
| @@ -529,6 +530,13 @@ const json: RequirementsJson = { | |||
| advisors: eceMinorAdvisors, | |||
| abbrev: 'ECE', | |||
| }, | |||
| ECONILR: { | |||
| name: 'Economics for ILR Students', | |||
There was a problem hiding this comment.
Another minor, information science in engineering, wrote the minor like this
Information Science [Engineering]
should we keep the same semantics for consistency?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds functionality for individuals to take the ILR Economics minor.
For details, please see here and here.
Test Plan
You can go into your profile and add an ILR economics minor, then confirm that associated requirements are added in as expected.
Notes