-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support ILR Econ Minor #959
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
d35a3c8
chore: add ilr minor
Destaq 22c8cb0
fix: update test cases
Destaq e2f463a
refactor: make college-specific minor name for ilr econ minor more co…
Destaq 81e816b
chore: add note about study abroad exception
Destaq 001f94d
chore: update requirements json
Destaq File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,95 @@ | ||
import { CollegeOrMajorRequirement, Course } from '../../requirements/types'; | ||
import { | ||
includesWithSubRequirements, | ||
ifCodeMatch, | ||
courseMatchesCodeOptions, | ||
} from '../../requirements/checkers'; | ||
import { AdvisorGroup } from '../../tools/advisors/types'; | ||
|
||
const econILRMinorRequirements: readonly CollegeOrMajorRequirement[] = [ | ||
{ | ||
name: 'Prerequisites', | ||
description: | ||
'MATH 1110 with grade C or better, ECON 1110 and ECON 1120 with grades B- or better.', | ||
source: 'https://economics.cornell.edu/minor', | ||
checker: includesWithSubRequirements(['MATH 1110'], ['ECON 1110'], ['ECON 1120']), | ||
fulfilledBy: 'courses', | ||
perSlotMinCount: [1, 1, 1], | ||
slotNames: ['MATH 1110', 'ECON 1110', 'ECON 1120'], | ||
checkerWarning: | ||
'ECON 1110 or ECON 1120 will count toward the Economics Minor only if credit for the course appears on your Cornell transcript.', | ||
}, | ||
{ | ||
name: 'Intermediate Courses', | ||
description: 'ECON 3030 and ECON 3040. Must be taken at Cornell.', | ||
source: 'https://economics.cornell.edu/minor', | ||
checker: includesWithSubRequirements(['ECON 3030'], ['ECON 3040']), | ||
fulfilledBy: 'courses', | ||
perSlotMinCount: [1, 1], | ||
slotNames: ['ECON 3030', 'ECON 3040'], | ||
}, | ||
{ | ||
name: 'Statistics and Econometrics', | ||
description: | ||
'Option 1: ECON 3110 and ECON 3120. Option 2: ECON 3130 and ECON 3140. Must be taken at Cornell.', | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Looks good! |
||
source: 'https://economics.cornell.edu/minor', | ||
fulfilledBy: 'toggleable', | ||
fulfillmentOptions: { | ||
'Option 1': { | ||
description: 'ECON 3110 and ECON 3120', | ||
counting: 'courses', | ||
checker: includesWithSubRequirements(['ECON 3110'], ['ECON 3120']), | ||
perSlotMinCount: [1, 1], | ||
slotNames: ['ECON 3110', 'ECON 3120'], | ||
}, | ||
'Option 2': { | ||
description: 'ECON 3130 and ECON 3140', | ||
counting: 'courses', | ||
checker: includesWithSubRequirements(['ECON 3130'], ['ECON 3140']), | ||
perSlotMinCount: [1, 1], | ||
slotNames: ['ECON 3130', 'ECON 3140'], | ||
}, | ||
}, | ||
}, | ||
{ | ||
name: 'Additional ECON Courses', | ||
description: | ||
'Additional 3000 or 4000 level ECON courses to reach a total of 9 courses. ' + | ||
'ECON 4990, 4991, and 4999 cannot be counted. ' + | ||
'At least 5 of your 3000/4000-level courses must be taken at Cornell. ' + | ||
'The exception for this is for Study Abroad, in which you must take at least 4 of these courses at Cornell.', | ||
source: 'https://economics.cornell.edu/minor', | ||
checker: [ | ||
(course: Course): boolean => { | ||
if ( | ||
courseMatchesCodeOptions(course, [ | ||
'ECON 4990', | ||
'ECON 4991', | ||
'ECON 4999', | ||
'ECON 3030', | ||
'ECON 3040', | ||
'ECON 3110', | ||
'ECON 3120', | ||
'ECON 3130', | ||
'ECON 3140', | ||
]) | ||
) { | ||
return false; | ||
} | ||
return ( | ||
ifCodeMatch(course.subject, 'ECON') && | ||
(ifCodeMatch(course.catalogNbr, '3***') || ifCodeMatch(course.catalogNbr, '4***')) | ||
); | ||
}, | ||
], | ||
fulfilledBy: 'courses', | ||
perSlotMinCount: [3], | ||
slotNames: ['Course'], | ||
}, | ||
]; | ||
|
||
export default econILRMinorRequirements; | ||
|
||
export const econILRMinorAdvisors: AdvisorGroup = { | ||
advisors: [{ name: 'Sarah Louise Schupp', email: '[email protected]' }], | ||
}; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aligned with the current rubric.