-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 2.0 #68
Merged
Merged
Release 2.0 #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… unless at snow-ice interface; merge small ice layers
…g results correctly
Bug fix on the surface temperature solver
Refactors: - get_total_foo and get_number_snow_layers now sum the output of the method they duplicated. - Unused overburden pressure in merge_nodes. - String operations. Adds: - Relevant tests.
Removes `-c` arguments as these conflict with configuration imports. Refactors inconsistent documentation, illegible code.
Re-implements output variable selection to fix dask OOM errors when using SLURM. The output variables are now read from the config.toml file instead of the output/output.full files.
Fixes: - Date comparisons comparing lengths of strings instead of time. - Incorrect type for self.restart_date. Refactors: - Streamlines saving to loop over user selected variables. - Removes duplicate code.
Fixes crash caused when passing an empty string to output_variable in config
Fix readthedocs, mock imports, outdated docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This release is not backwards-compatible with previous versions of COSIPY!
Tested on Ubuntu 22.04 & 24.04, Python 3.9 to 3.12, with and without Slurm.
Main Features:
convert_config.py
.Breaking Changes:
output
andoutput.full
files. Output variable selection is now in the config file.-c
,-x
,-u
,-s
are now reserved for handling configuration files.Details
Critical Bug Fixes
Configuration
Configuration system now uses .toml files. You can now run multiple simulations from the same root directory. You can now select from multiple configuration files in any directory via optional user arguments:
This system is not backwards-compatible, but you can convert your existing configuration files:
If you have custom scripts importing constants or config variables, these will break. Look at
densification.py
to see how these are now implemented: if you want to access constants or config variables within an njitted function, these must be declared at the module level. Otherwise, replaceimport constants
withfrom cosipy.constants import Constants
.Packaging
COSIPY now supports pip installation as a package or editable. This centralises the file hierarchy, so utilities and postprocessing are now under
cosipy
. Installing COSIPY as a package or editable adds entry points to simplify your workflow. View these usingcosipy-shortcuts
.When running COSIPY from source, you will need to modify your commands, e.g.:
Optimisations
Documentation
CI workflow
Code pushed to master or release branches is automatically tested with python 3.9-3.12 on Ubuntu.
Fixes #8, fixes #9, fixes #42, fixes #64.
Closes #59, closes #66.