Avoid leaking hostname on failed hostname verification #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
what did we decide to do with this PR? were we going to move this logic into secretless, and did we do that? thanks! |
|
@izgeri I’m not really sure how to proceed. This PR doesn’t seem all that valuable in the backdrop of a myriad of other errors that will disclose the host name, whether we hide it here or in Secretless. |
|
this is one that we have control over, so we should hide it if we can (especially if we can logically do it by catching a certain type of error) it's ok with me if we file an issue to follow up with this logic in secretless, though - @doodlesbykumbi can you file the issue, reference it here, and close this PR? |
|
Closed in favour of cyberark/secretless-broker#1229 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.