Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid leaking hostname on failed hostname verification #26

Closed
wants to merge 1 commit into from
Closed

Avoid leaking hostname on failed hostname verification #26

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions tds.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1171,6 +1171,10 @@ initiate_connection:
passthrough.c = toconn
outbuf.transport = tlsConn
if err != nil {
hErr, ok := err.(x509.HostnameError)
if ok && strings.HasPrefix(hErr.Error(), "x509: certificate is valid for") {
err = fmt.Errorf("certificate is not valid for hostname")
}
return nil, fmt.Errorf("TLS Handshake failed: %v", err)
}
if encrypt == EncryptOff {
Expand Down