-
-
Notifications
You must be signed in to change notification settings - Fork 8
feat: make compatible with deno 1.7 #48
base: main
Are you sure you want to change the base?
Conversation
c41e3df
to
29ab833
Compare
@jeiea It seems necessary to update the version number of Deno in ( |
Thanks for the comment. I'll try it few hours later. |
Commented on one point. Otherwise LGTM. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jeiea Thanks for the update. LGTM.
Co-authored-by: Luca Casonato <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This looks ready to land now. What do you think? @lucacasonato @jeroenptrs
It does not work with deno 1.8 ( |
Never mind. It was my configuration miss. |
what about an approbal? we need this. |
Close #46.
I tested it with only my use cases. It's my first contribution to this repository so feel free to review or close.