Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update 404 page to use ds classes #334

Merged
merged 4 commits into from
Jan 12, 2024
Merged

update 404 page to use ds classes #334

merged 4 commits into from
Jan 12, 2024

Conversation

tjheffner
Copy link
Contributor

@tjheffner tjheffner commented Jan 11, 2024

Description

Relates to these slack discussions:
https://dsva.slack.com/archives/CBU0KDSB1/p1704994672158839
https://dsva.slack.com/archives/C03LFSPGV16/p1704994189923529

An equivalent PR will be made to the va.gov-content repo's 404 page.

Testing done

Looked at the 404 page in next-build and tweaked it to use actual VADS classes based on the styles removed in this pr: https://github.com/department-of-veterans-affairs/vets-website/pull/27086/files

Screenshots

QA steps

What needs to be checked to prove this works?
What needs to be checked to prove it didn't break any related things?
What variations of circumstances (users, actions, values) need to be checked?

Tasks

Preview Give feedback

Is this PR blocked by another PR?

  • Add the DO NOT MERGE label
  • Add links to additional PRs here:

@va-cms-bot va-cms-bot temporarily deployed to Tugboat January 11, 2024 20:25 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat January 11, 2024 22:28 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat January 11, 2024 22:35 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat January 11, 2024 23:33 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat January 11, 2024 23:43 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat January 11, 2024 23:49 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat January 11, 2024 23:52 Destroyed
@tjheffner
Copy link
Contributor Author

tjheffner commented Jan 12, 2024

this is a valid test failure, the class the test was looking for has been removed. will update.

1) [main] › 404page.spec.js:4:3 › 404 Error Page › Displays the 404 Error page content ───────────

    Error: Timed out 5000ms waiting for expect(locator).toBeVisible()

    Locator: locator('.va-quicklinks--commpop')
    Expected: visible
    Received: hidden
    Call log:
      - expect.toBeVisible with timeout 5000ms
      - waiting for locator('.va-quicklinks--commpop')


      16 |     await expect(page.locator('form#search_form')).toBeVisible()
      17 |
    > 18 |     await expect(page.locator('.va-quicklinks--commpop')).toBeVisible()
         |                                                           ^
      1[9](https://github.com/department-of-veterans-affairs/next-build/actions/runs/7495981042/job/20407142357?pr=334#step:8:10) |   })
      20 |
      21 |   test('Should render without a[11](https://github.com/department-of-veterans-affairs/next-build/actions/runs/7495981042/job/20407142357?pr=334#step:8:12)y accessibility errors', async ({

        at /__w/next-build/next-build/playwright/tests/404page.spec.js:[18](https://github.com/department-of-veterans-affairs/next-build/actions/runs/7495981042/job/20407142357?pr=334#step:8:19):59

@tjheffner tjheffner merged commit 21a2b99 into main Jan 12, 2024
7 checks passed
@tjheffner tjheffner deleted the 404-fix branch January 12, 2024 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants