Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Lovell switch link code from VBA Facility file #17904

Closed
1 task done
laflannery opened this issue Apr 19, 2024 · 0 comments
Closed
1 task done

Remove Lovell switch link code from VBA Facility file #17904

laflannery opened this issue Apr 19, 2024 · 0 comments
Assignees
@eselkin
Labels
Facilities Facilities products (VAMC, Vet Center, etc) Regional office CMS managed VBA product owned by the Facilities team sitewide Technical debt VA.gov frontend CMS team practice area

Comments

@laflannery
Copy link
Contributor

laflannery commented Apr 19, 2024 •
edited by eselkin
Loading

Description

Within the VBA Facility GitHub file the code for the Lovell switch link was accidentally copy/pasted in:

Screenshot 2024-04-19 at 1 18 20 PM

This isn't currently showing on the front end at all so it's not creating any sort of issue. However, I wonder if we should consider removing it because I don't think we will ever need this and knowing the weirdness of Lovell we probably don't want this anywhere we aren't expecting it.

steps to implement

  • Take out any Lovell code
  • Check both Lovell and VBA in a Tugboat or test env

Acceptance Criteria

  • Lovell code should not appear in VBA templates
@laflannery laflannery added Needs refining Issue status VA.gov frontend CMS team practice area Facilities Facilities products (VAMC, Vet Center, etc) Regional office CMS managed VBA product owned by the Facilities team labels Apr 19, 2024
@jilladams jilladams mentioned this issue Apr 22, 2024
Closed
22 tasks
@jilladams jilladams removed the Needs refining Issue status label Apr 22, 2024
@jilladams jilladams mentioned this issue Apr 22, 2024
Closed
@jilladams jilladams mentioned this issue May 3, 2024
Closed
This was referenced May 17, 2024
Closed
Closed
@Agile6MSkinner Agile6MSkinner changed the title Consider removing Lovell switch link code from VBA Facility file Remove Lovell switch link code from VBA Facility file Jul 3, 2024
@eselkin eselkin mentioned this issue Jul 23, 2024
Merged
11 tasks
@eselkin eselkin self-assigned this Jul 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eselkin eselkin

Labels
Facilities Facilities products (VAMC, Vet Center, etc) Regional office CMS managed VBA product owned by the Facilities team sitewide Technical debt VA.gov frontend CMS team practice area
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@eselkin @jilladams @laflannery