Code

VAGOV-TEAM-99444: Form Info page#20311

Code

Merged

ryguyk merged 36 commits intomaindepartment-of-veterans-affairs/va.gov-cms:mainfrom VAGOV-TEAM-99444-form-infodepartment-of-veterans-affairs/va.gov-cms:VAGOV-TEAM-99444-form-infoCopy head branch name to clipboardJan 24, 2025

+991-753

Commits

Commits on Jan 24, 2025

• Renames start-conversion to form-name. Adjusts routing, tests, etc.

  ryguyk

  committed
  b43ab39

  Copy full SHA for b43ab39

• Defines two routes (create, edit) for form-name page. Uses same controller method to handle the two routes.

  ryguyk

  committed
  b350949

  Copy full SHA for b350949

• Adds method to DigitalFormsService to fetch individual Digital Form node.

  ryguyk

  committed
  5d1fc70

  Copy full SHA for 5d1fc70

• - Moves base Form logic to FormBuilderBase. (FormBuilderNodeBase and FormBuilderEditBase will be removed later).

  Show description for 1cb3f8e
  ryguyk

  committed
  1cb3f8e

  Copy full SHA for 1cb3f8e

• Updates controller to handle loading/passing of Digital Form node when nid is passed in.

  ryguyk

  committed
  94c363f

  Copy full SHA for 94c363f

• Adds entityTypeManager as explicity dependency of FormBuilderBase.

  Show description for b07cffb
  ryguyk

  committed
  b07cffb

  Copy full SHA for b07cffb

• - Sets default values on form fields when in "edit" mode.

  Show description for cf565b1
  ryguyk

  committed
  cf565b1

  Copy full SHA for cf565b1

• Removes $nid from calls to getFormPage

  ryguyk

  committed
  66c6c8f

  Copy full SHA for 66c6c8f

• - Removes FormBuilderNodeBase and FormBuilderEditBase.

  Show description for 9d62ff2
  ryguyk

  committed
  9d62ff2

  Copy full SHA for 9d62ff2

• - Adds flag to indicate whether the node can be empty.

  Show description for 676b6a2
  ryguyk

  committed
  676b6a2

  Copy full SHA for 676b6a2

• Adds loading of digital form by node id to nameAndDob controller method.

  ryguyk

  committed
  008edaf

  Copy full SHA for 008edaf

• Moves isCreate flag and logic from base form to FormName form, as this is the only form that should have this.

  ryguyk

  committed
  7d37d58

  Copy full SHA for 7d37d58

• Sets back-button redirect to the edit page rather than create page.

  ryguyk

  committed
  6fabcd3

  Copy full SHA for 6fabcd3

• Removes test classes for now-unused Form base classes. Combines tests into remaining base class.

  ryguyk

  committed
  28eced2

  Copy full SHA for 28eced2

• Removes condition to only save on updated node. Doesn't apply here (at least yet).

  ryguyk

  committed
  b2a8c2e

  Copy full SHA for b2a8c2e

• Updates tests for controller.

  ryguyk

  committed
  31376cd

  Copy full SHA for 31376cd

• Updates tests for FormName form.

  ryguyk

  committed
  60d0718

  Copy full SHA for 60d0718

• Small update to test for back button on NameAndDobTest

  ryguyk

  committed
  e859adf

  Copy full SHA for e859adf

• Removes unnecessary check for empty value.

  ryguyk

  committed
  a8a5cfc

  Copy full SHA for a8a5cfc

• Adds unit test for getDigitalForm method on the service.

  ryguyk

  committed
  0ac61a2

  Copy full SHA for 0ac61a2

• Changes "Form Name" to "Form Info". Updates routes, class names, etc.

  ryguyk

  committed
  61da8f5

  Copy full SHA for 61da8f5

• Updates page title and removes help text.

  ryguyk

  committed
  f6dd0c5

  Copy full SHA for f6dd0c5

• Changes "Continue" button text to "Save and continue".

  ryguyk

  committed
  bc14c00

  Copy full SHA for bc14c00

• Change page subtitle on Form Info page.

  ryguyk

  committed
  56c4424

  Copy full SHA for 56c4424

• Removes redundant drupalGet callls. This is handled in the shared methods called immediately after.

  ryguyk

  committed
  0ae5372

  Copy full SHA for 0ae5372

• - Adds tests asserting correct subtitle.

  Show description for e7543b4
  ryguyk

  committed
  e7543b4

  Copy full SHA for e7543b4

• - Removes back button on Form Info page.

  Show description for bc92d7a
  ryguyk

  committed
  bc92d7a

  Copy full SHA for bc92d7a

• Changes required field label to "(*Required)" rather than just an asterisk "*".

  ryguyk

  committed
  a08b2c8

  Copy full SHA for a08b2c8

• Removes help text from various fields.

  ryguyk

  committed
  a112929

  Copy full SHA for a112929

• Configures custom template and css for Form Info page.

  ryguyk

  committed
  0acc217

  Copy full SHA for 0acc217

• Renders form via template and styles via css.

  ryguyk

  committed
  e0a619a

  Copy full SHA for e0a619a

• Changes color on form-field hint text.

  ryguyk

  committed
  429837e

  Copy full SHA for 429837e

• Updates test to align with updated page text.

  ryguyk

  committed
  b21b770

  Copy full SHA for b21b770

• Updates LibrariesTest to check for new libraries.

  ryguyk

  committed
  190598f

  Copy full SHA for 190598f

• Updates ModuleTest to ensure presence of form themes.

  ryguyk

  committed
  8a1f175

  Copy full SHA for 8a1f175

• Makes form elements fill form width so they all match.

  ryguyk

  committed
  7f0adc4

  Copy full SHA for 7f0adc4