-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VAGOV-TEAM-99444: Form Info page #20311
Merged
Merged
Changes from all commits
Commits
Show all changes
36 commits
Select commit
Hold shift + click to select a range
b43ab39
Renames start-conversion to form-name. Adjusts routing, tests, etc.
ryguyk b350949
Defines two routes (create, edit) for form-name page. Uses same contr…
ryguyk 5d1fc70
Adds method to DigitalFormsService to fetch individual Digital Form n…
ryguyk 1cb3f8e
- Moves base Form logic to FormBuilderBase. (FormBuilderNodeBase and …
ryguyk 94c363f
Updates controller to handle loading/passing of Digital Form node whe…
ryguyk b07cffb
Adds entityTypeManager as explicity dependency of FormBuilderBase.
ryguyk cf565b1
- Sets default values on form fields when in "edit" mode.
ryguyk 66c6c8f
Removes $nid from calls to `getFormPage`
ryguyk 9d62ff2
- Removes FormBuilderNodeBase and FormBuilderEditBase.
ryguyk 676b6a2
- Adds flag to indicate whether the node can be empty.
ryguyk 008edaf
Adds loading of digital form by node id to nameAndDob controller method.
ryguyk 7d37d58
Moves `isCreate` flag and logic from base form to FormName form, as t…
ryguyk 6fabcd3
Sets back-button redirect to the edit page rather than create page.
ryguyk 28eced2
Removes test classes for now-unused Form base classes. Combines tests…
ryguyk b2a8c2e
Removes condition to only save on updated node. Doesn't apply here (a…
ryguyk 31376cd
Updates tests for controller.
ryguyk 60d0718
Updates tests for FormName form.
ryguyk e859adf
Small update to test for back button on NameAndDobTest
ryguyk a8a5cfc
Removes unnecessary check for empty value.
ryguyk 0ac61a2
Adds unit test for `getDigitalForm` method on the service.
ryguyk 61da8f5
Changes "Form Name" to "Form Info". Updates routes, class names, etc.
ryguyk f6dd0c5
Updates page title and removes help text.
ryguyk bc14c00
Changes "Continue" button text to "Save and continue".
ryguyk 56c4424
Change page subtitle on Form Info page.
ryguyk 0ae5372
Removes redundant `drupalGet` callls. This is handled in the shared m…
ryguyk e7543b4
- Adds tests asserting correct subtitle.
ryguyk bc92d7a
- Removes back button on Form Info page.
ryguyk a08b2c8
Changes required field label to "(*Required)" rather than just an ast…
ryguyk a112929
Removes help text from various fields.
ryguyk 0acc217
Configures custom template and css for Form Info page.
ryguyk e0a619a
Renders form via template and styles via css.
ryguyk 429837e
Changes color on form-field hint text.
ryguyk b21b770
Updates test to align with updated page text.
ryguyk 190598f
Updates LibrariesTest to check for new libraries.
ryguyk 8a1f175
Updates ModuleTest to ensure presence of form themes.
ryguyk 7f0adc4
Makes form elements fill form width so they all match.
ryguyk File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
15 changes: 15 additions & 0 deletions
15
docroot/modules/custom/va_gov_form_builder/css/va_gov_form_builder__form_info.css
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,15 @@ | ||
.form-builder-page-content--form-info { | ||
width: 335px; | ||
} | ||
|
||
.form-builder-page-content--form-info .form-element { | ||
width: 100%; | ||
} | ||
|
||
.form-builder-content-section { | ||
border-bottom: 1px solid var(--vads-color-base-light); | ||
} | ||
|
||
h3.form-builder-content-section__header { | ||
font-size: var(--vads-font-size-heading-level-4); | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This base class was initially used, then went through a time where the only logic it had was removed. Now, the need for two layers here (three separate base classes) has gone away, and this class is the only base class, so a lot of the logic from the others has been moved in here and this class has gotten new life.