Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added form 10-7959a pagerduty service to settings.yml #21049

Merged
merged 7 commits into from
Mar 5, 2025

Conversation

michaelclement
Copy link
Contributor

Summary

This PR adds the Pager Duty service ID for the newly created Production: External: 10-7959a form service in Pager Duty. This is so we can schedule maintenance windows/downtimes for the form application.

Related issue(s)

Testing done

  • New code is covered by unit tests
  • Describe what the old behavior was prior to the change
  • Describe the steps required to verify your changes are working as expected. Exclusively stating 'Specs run' is NOT acceptable as appropriate testing
  • If this work is behind a flipper:
    • Tests need to be written for both the flipper on and flipper off scenarios. Docs.
    • What is the testing plan for rolling out the feature?

Screenshots

NA

What areas of the site does it impact?

IVC forms 10-7959a

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • Documentation has been updated (link to documentation)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog (if applicable)
  • If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
  • I added a screenshot of the developed feature

Requested Feedback

(OPTIONAL)What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?

@va-vfs-bot va-vfs-bot temporarily deployed to 102216-pagerduty-create-a-service-for-10-7959a/102216-pagerduty-create-a-service-for-10-7959a/main March 3, 2025 19:51 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to 102216-pagerduty-create-a-service-for-10-7959a/102216-pagerduty-create-a-service-for-10-7959a/main March 3, 2025 20:39 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to 102216-pagerduty-create-a-service-for-10-7959a/102216-pagerduty-create-a-service-for-10-7959a/main March 3, 2025 22:15 Inactive
brostk
brostk previously approved these changes Mar 4, 2025
@va-vfs-bot va-vfs-bot temporarily deployed to 102216-pagerduty-create-a-service-for-10-7959a/102216-pagerduty-create-a-service-for-10-7959a/main March 4, 2025 16:20 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to 102216-pagerduty-create-a-service-for-10-7959a/102216-pagerduty-create-a-service-for-10-7959a/main March 4, 2025 16:36 Inactive
Copy link
Contributor

@stevelong00 stevelong00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@va-vfs-bot va-vfs-bot temporarily deployed to 102216-pagerduty-create-a-service-for-10-7959a/102216-pagerduty-create-a-service-for-10-7959a/main March 4, 2025 19:46 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to 102216-pagerduty-create-a-service-for-10-7959a/102216-pagerduty-create-a-service-for-10-7959a/main March 4, 2025 21:34 Inactive
@michaelclement michaelclement marked this pull request as ready for review March 4, 2025 21:59
@michaelclement michaelclement requested a review from a team as a code owner March 4, 2025 21:59
@michaelclement michaelclement enabled auto-merge (squash) March 5, 2025 18:04
@rjohnson2011 rjohnson2011 disabled auto-merge March 5, 2025 18:09
@rjohnson2011 rjohnson2011 merged commit 6f5da72 into master Mar 5, 2025
33 of 35 checks passed
@rjohnson2011 rjohnson2011 deleted the 102216-pagerduty-create-a-service-for-10-7959a branch March 5, 2025 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants