Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update: migrate jhipster online to red hat developer demo #545

Merged
merged 6 commits into from
Jan 10, 2025
Merged

update: migrate jhipster online to red hat developer demo #545

merged 6 commits into from
Jan 10, 2025

Conversation

maximilianoPizarro
Copy link
Contributor

Description of Changes

Migrate jhipster online to red hat developer demo repo and image to quay devfile organization

GitHub
https://github.com/redhat-developer-demos/jhipster-online

Quay
https://quay.io/repository/devfile/jhipster-online

Related Issue(s)

Link the GitHub/GitLab/JIRA issues that are related to this PR.

How To Test

Instructions for the reviewer on how to test your changes.

Taking a look at the Video Demo

@maximilianoPizarro maximilianoPizarro requested review from a team as code owners January 7, 2025 19:29
@openshift-ci openshift-ci bot requested review from johnmcollier and thepetk January 7, 2025 19:29
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jan 7, 2025

Hi @maximilianoPizarro. Thanks for your PR.

I'm waiting for a devfile member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@michael-valdron
Copy link
Member

/ok-to-test

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jan 7, 2025

@maximilianoPizarro: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/v4.15-registry-test 611cd5b link true /test v4.15-registry-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

thepetk
thepetk approved these changes Jan 8, 2025
View reviewed changes
Copy link
Contributor

@thepetk thepetk left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm after all checks are passing.

IIRC #531 needs to be merged first

/hold

svor
svor approved these changes Jan 8, 2025
View reviewed changes
Copy link
Collaborator

@svor svor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm
screenshot-jenkins-csb-crwqe-main_dno_corp_redhat_com-2025_01_08-15_39_03

@openshift-ci openshift-ci bot added lgtm Looks good to me approved labels Jan 8, 2025
michael-valdron
michael-valdron reviewed Jan 9, 2025
View reviewed changes
Copy link
Member

@michael-valdron michael-valdron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm after all checks are passing.

IIRC #531 needs to be merged first

/hold

@maximilianoPizarro Just needs a rebase to apply the testing fixes and should be good to go.

@michael-valdron
Copy link
Member

/unhold

@openshift-ci openshift-ci bot removed the lgtm Looks good to me label Jan 10, 2025
team-devfile-bot and others added 6 commits January 10, 2025 12:58
@team-devfile-bot @maximilianoPizarro
Trigger deploy based on devfile/devfile-web@f540461
6196f72 
Signed-off-by: Maximiliano Pizarro <[email protected]>
@maximilianoPizarro
migrate jhipster online to redhat developer demos
6031031 
Signed-off-by: Maximiliano Pizarro <[email protected]>
@team-devfile-bot @maximilianoPizarro
Trigger deploy based on devfile/devfile-web@f540461
1ffebe1 
Signed-off-by: Maximiliano Pizarro <[email protected]>
@michael-valdron @maximilianoPizarro
Fix PR integration testing (devfile#531)
1dcb297 
* tls enablement for check_odov2.sh and openshift_integration.sh

Signed-off-by: Michael Valdron <[email protected]>

* replace odov2 with odov3 under integration testing

Signed-off-by: Michael Valdron <[email protected]>

* fix missing ginkgo and test script argument steps

Signed-off-by: Michael Valdron <[email protected]>

* correct ENABLE_TLS to ENABLE_TLS_VERIFY for odov2 test script

Signed-off-by: Michael Valdron <[email protected]>

* remove ENABLE_TLS_VERIFY for odov3 test script run under integration testing script

Signed-off-by: Michael Valdron <[email protected]>

* revert showing full odo path in test log

Signed-off-by: Michael Valdron <[email protected]>

* openshift_integration: fix remaining file path references to use BASE_DIR instead of relative path

Signed-off-by: Michael Valdron <[email protected]>

---------

Signed-off-by: Michael Valdron <[email protected]>
Signed-off-by: Maximiliano Pizarro <[email protected]>
@michael-valdron @maximilianoPizarro
patch konflux pipeline task images (devfile#546)
f44040c 
Signed-off-by: Michael Valdron <[email protected]>
Signed-off-by: Maximiliano Pizarro <[email protected]>
@team-devfile-bot @maximilianoPizarro
Trigger deploy based on devfile/devfile-web@f540461
e923d94 
Signed-off-by: Maximiliano Pizarro <[email protected]>
@ibuziuk ibuziuk mentioned this pull request Jan 10, 2025
Open
michael-valdron
michael-valdron approved these changes Jan 10, 2025
View reviewed changes
Copy link
Member

@michael-valdron michael-valdron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Looks good to me label Jan 10, 2025
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jan 10, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ibuziuk, maximilianoPizarro, michael-valdron, svor, thepetk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [michael-valdron,thepetk]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@michael-valdron michael-valdron merged commit 650948c into devfile:main Jan 10, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michael-valdron michael-valdron michael-valdron approved these changes

@thepetk thepetk thepetk approved these changes

@ibuziuk ibuziuk ibuziuk approved these changes

@svor svor svor approved these changes

@johnmcollier johnmcollier Awaiting requested review from johnmcollier

Assignees

@svor svor

@ibuziuk ibuziuk

@michael-valdron michael-valdron

Labels
approved lgtm Looks good to me ok-to-test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@maximilianoPizarro @michael-valdron @svor @ibuziuk @thepetk @team-devfile-bot