Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Adding JHipster devfile #112

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: Adding JHipster devfile #112

wants to merge 1 commit into from

Conversation

ibuziuk
Copy link
Member

@ibuziuk ibuziuk commented Dec 16, 2024

@ibuziuk ibuziuk requested a review from l0rd as a code owner December 16, 2024 12:17
Copy link

Click here to review and test in web IDE: Contribute

@ibuziuk ibuziuk requested a review from dkwon17 December 18, 2024 12:02
@ibuziuk
Copy link
Member Author

ibuziuk commented Dec 18, 2024

@maximilianoPizarro hello, I want to promote the devfile you contributed to the Eclipse Che website, but it does not seem to work on Developer Sandbox / workspaces.openshift.com

Screenshot 2024-12-18 at 13 09 49

I believe the first problem is here - https://github.com/maximilianoPizarro/jhipster-online/blob/main/src/main/kubernetes/mysql.yaml#L118

can we use a different / non-internal image?

Screenshot 2024-12-18 at 13 19 30

@maximilianoPizarro
Copy link

Hi @ibuziuk,
I changed the mariadb manifest image to the redhat.io external registry.
Please try now and let me know if work :)

@maximilianoPizarro hello, I want to promote the devfile you contributed to the Eclipse Che website, but it does not seem to work on Developer Sandbox / workspaces.openshift.com

Screenshot 2024-12-18 at 13 09 49 I believe the first problem is here - https://github.com/maximilianoPizarro/jhipster-online/blob/main/src/main/kubernetes/mysql.yaml#L118

can we use a different / non-internal image?

Screenshot 2024-12-18 at 13 19 30

Hi, @ibuziuk!

I changed the mariadb manifest image to the external registry of redhat.io.

Try it now and let me know if it works :)

@ibuziuk
Copy link
Member Author

ibuziuk commented Dec 18, 2024

@maximilianoPizarro thank you for the quick follow-up. Just wondering why do you have a separate openshift branch for sample? are you going to change the image in main as well?

@maximilianoPizarro
Copy link

@maximilianoPizarro thank you for the quick follow-up. Just wondering why do you have a separate openshift branch for sample? are you going to change the image in main as well?

Thanks @ibuziuk for trying it out and adding it to the eclipse-che website!
I updated the main branch of my fork with the manifest mariadb change. The added devfile.yaml points to the openshift branch by default.

@maximilianoPizarro
Copy link

Hi Team. Do you need anything from me to move forward with this PR? Thanks in advance 🙂

@ibuziuk
Copy link
Member Author

ibuziuk commented Dec 24, 2024

@maximilianoPizarro thanks you for the follow up. The PR still need to be reviewed and approved cc: @dkwon17
we will reconnect in January. Happy Holidays, and thank you for the contribution \o/

@ibuziuk
Copy link
Member Author

ibuziuk commented Dec 24, 2024

@maximilianoPizarro not sure why but looks like the sample is not working anymore :/
I suspect that the problem is related to the image / digest that does not seem to be public anymore.
Would it be possible to update the original devfile and some comon image for this setup e.g. UDI

Screenshot 2024-12-24 at 17 51 00

@maximilianoPizarro
Copy link

It's possible that it's an availability bug in Quay.io, as I just tested it and the download works fine.

Screenshot_2024-12-24-14-14-08-254_com.android.chrome.jpg

It seems that they are migrating Quay.io to the Red Hat Customers portal to 1/01/2025.

We can make that change from devfile so that it takes UDI and jhipster-cli is installed in a task package when workspace started, also I need check java version. I'll work on it from a new PR to the project devfile.

We can move forward in parallel with this PR if the team is okay with it, as the change will keep the same version 2.33.0 and the URI to the devfile.

I'll keep you posted as soon as I have the PR so you can follow it.

Happy Holiday's!

@ibuziuk
Copy link
Member Author

ibuziuk commented Jan 10, 2025

@maximilianoPizarro thank you for the follow-up. Will wait for devfile/registry#545 been merged and re-test the whole flow

@maximilianoPizarro
Copy link

Good news @ibuziuk. It works with the latest change in production.

image

Now we can move forward with this aggregation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants