-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Adding JHipster devfile #112
base: main
Are you sure you want to change the base?
Conversation
@maximilianoPizarro hello, I want to promote the devfile you contributed to the Eclipse Che website, but it does not seem to work on Developer Sandbox / workspaces.openshift.com I believe the first problem is here - https://github.com/maximilianoPizarro/jhipster-online/blob/main/src/main/kubernetes/mysql.yaml#L118 can we use a different / non-internal image? |
Hi @ibuziuk,
Hi, @ibuziuk! I changed the mariadb manifest image to the external registry of redhat.io. Try it now and let me know if it works :) |
@maximilianoPizarro thank you for the quick follow-up. Just wondering why do you have a separate |
Thanks @ibuziuk for trying it out and adding it to the eclipse-che website! |
Hi Team. Do you need anything from me to move forward with this PR? Thanks in advance 🙂 |
@maximilianoPizarro thanks you for the follow up. The PR still need to be reviewed and approved cc: @dkwon17 |
@maximilianoPizarro not sure why but looks like the sample is not working anymore :/ |
It's possible that it's an availability bug in Quay.io, as I just tested it and the download works fine. It seems that they are migrating Quay.io to the Red Hat Customers portal to 1/01/2025. We can make that change from devfile so that it takes UDI and jhipster-cli is installed in a task package when workspace started, also I need check java version. I'll work on it from a new PR to the project devfile. We can move forward in parallel with this PR if the team is okay with it, as the change will keep the same version 2.33.0 and the URI to the devfile. I'll keep you posted as soon as I have the PR so you can follow it. Happy Holiday's! |
@maximilianoPizarro thank you for the follow-up. Will wait for devfile/registry#545 been merged and re-test the whole flow |
Good news @ibuziuk. It works with the latest change in production. Now we can move forward with this aggregation. |
https://www.youtube.com/watch?v=b7xbcTAGNIQ