fix(styles): correct number and text overlap in Safari #6369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yhabib
changed the title
yhabib
force-pushed
the
nns1-3606/safari-bug
branch
from
dd36d37 to
51b8c78
Compare
yhabib
commented
Feb 7, 2025
dskloetd
reviewed
Feb 10, 2025
dskloetd
approved these changes
Feb 10, 2025
yhabib
force-pushed
the
nns1-3606/safari-bug
branch
from
51b8c78 to
6809ade
Compare
1 task
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 10, 2025
# Motivation In #6369, I accidentally added two screenshots taken locally on the Mac. We should only include screenshots captured while running the e2e in the CI. # Changes - Removes screenshots. # Tests - Tests should pass as before # Todos - [ ] Add entry to changelog (if necessary). Not necessary
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
There is a visual bug in Safari that affects the display of numbers and text within an
inline-gridand abaseline. This bug causes the numbers to overlap the text.Before:
Screen.Recording.2025-02-07.at.17.02.17.mov
After:
Screen.Recording.2025-02-07.at.17.02.55.mov
Fixes NNS1-3606
Changes
inline-gridtoinline-flexas it breaks in Safari.Tests
Todos
Not necessary