Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure LevelDB Iterator is closed #5458

Merged
merged 2 commits into from
Jan 12, 2025
Merged

Ensure LevelDB Iterator is closed #5458

merged 2 commits into from
Jan 12, 2025
+8 −8

Conversation

joshliebe
Copy link
Contributor

@joshliebe joshliebe commented Jan 11, 2025 •
edited
Loading

Task/Issue URL: https://app.asana.com/0/1200204095367872/1209128100809324/f

Description

  • Closes the DBIterator after local storage has been cleared.
  • Also keeps the DB open and updates the DB initialization to be Lazy.

Steps to test this PR

Filter logcat by WebLocalStorageManager

  • Visit cnn.com
  • Use the fire button
  • Verify that cnn.com entries are deleted

@joshliebe Graphite App
Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@joshliebe joshliebe merged commit d88e5ae into develop Jan 12, 2025
8 checks passed
@joshliebe joshliebe deleted the feature/josh/close-leveldb-iterator branch January 12, 2025 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aitorvs aitorvs aitorvs approved these changes

Assignees
No one assigned
Labels
QA-Optional
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joshliebe @aitorvs