Ensure LevelDB Iterator is closed

app/src/main/java/com/duckduckgo/app/browser/weblocalstorage/WebLocalStorageManager.kt

@@ -59,16 +59,17 @@ class DuckDuckGoWebLocalStorageManager @Inject constructor(
         Timber.d("WebLocalStorageManager: Matching regex: $matchingRegex")
 
         databaseProvider.get().use { db ->
-            val iterator = db.iterator()
-            iterator.seekToFirst()
+            db.iterator().use { iterator ->
+                iterator.seekToFirst()
 
-            while (iterator.hasNext()) {
-                val entry = iterator.next()
-                val key = String(entry.key, StandardCharsets.UTF_8)
+                while (iterator.hasNext()) {
+                    val entry = iterator.next()
+                    val key = String(entry.key, StandardCharsets.UTF_8)
 
-                if (!isAllowedKey(key)) {
-                    db.delete(entry.key)
-                    Timber.d("WebLocalStorageManager: Deleted key: $key")
+                    if (!isAllowedKey(key)) {
+                        db.delete(entry.key)
+                        Timber.d("WebLocalStorageManager: Deleted key: $key")
+                    }
                 }
             }
         }

app/src/test/java/com/duckduckgo/app/browser/DuckDuckGoWebLocalStorageManagerTest.kt

@@ -152,13 +152,14 @@ class DuckDuckGoWebLocalStorageManagerTest {
     }
 
     @Test
-    fun whenClearWebLocalStorageThenDBIsClosed() {
+    fun whenClearWebLocalStorageThenDBAndIteratorIsClosed() {
         whenever(mockDB.iterator()).thenReturn(mockIterator)
         whenever(mockIterator.hasNext()).thenReturn(false)
 
         testee.clearWebLocalStorage()
 
         verify(mockDB).close()
+        verify(mockIterator).close()
     }
 
     private fun createMockDBEntry(key: ByteArray): MutableMap.MutableEntry<ByteArray, ByteArray> {