Multi-selection: Add new FAB to the tab switcher #5467
+142
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
0nko
changed the title
0nko
force-pushed
the
feature/ondrej/tab-multi-selection
branch
from
0b382b2 to
8492b52
Compare
0nko
force-pushed
the
feature/ondrej/tab-multi-selection-fab
branch
from
67aa25e to
c303d4b
Compare
0nko
force-pushed
the
feature/ondrej/tab-multi-selection
branch
from
8492b52 to
c4c3cf8
Compare
0nko
force-pushed
the
feature/ondrej/tab-multi-selection-fab
branch
from
5916903 to
79bc6aa
Compare
0nko
force-pushed
the
feature/ondrej/tab-multi-selection
branch
from
c4c3cf8 to
c3270a9
Compare
0nko
force-pushed
the
feature/ondrej/tab-multi-selection-fab
branch
from
79bc6aa to
2acd9ec
Compare
0nko
force-pushed
the
feature/ondrej/tab-multi-selection
branch
from
c3270a9 to
e6e2148
Compare
0nko
force-pushed
the
feature/ondrej/tab-multi-selection-fab
branch
from
d85d6d1 to
6c267e1
Compare
0nko
force-pushed
the
feature/ondrej/tab-multi-selection
branch
from
e6e2148 to
ff15dd9
Compare
0nko
force-pushed
the
feature/ondrej/tab-multi-selection-fab
branch
from
6c267e1 to
ae833dd
Compare
This was referenced Feb 3, 2025
0nko
force-pushed
the
feature/ondrej/tab-multi-selection-fab
branch
from
ae833dd to
88714c8
Compare
0nko
force-pushed
the
feature/ondrej/tab-multi-selection
branch
from
ff15dd9 to
02fb482
Compare
0nko
requested review from
mikescamell
and removed request for
malmstein and
nalcalag
0nko
force-pushed
the
feature/ondrej/tab-multi-selection
branch
from
02fb482 to
b238763
Compare
0nko
force-pushed
the
feature/ondrej/tab-multi-selection-fab
branch
2 times, most recently
from
3987163 to
195a3f0
Compare
0nko
force-pushed
the
feature/ondrej/tab-multi-selection
branch
from
eab74f4 to
3d62cf6
Compare
0nko
force-pushed
the
feature/ondrej/tab-multi-selection
branch
from
3d62cf6 to
01126c4
Compare
0nko
force-pushed
the
feature/ondrej/tab-multi-selection-fab
branch
from
195a3f0 to
057e4d2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/72649045549333/1207969573539951
Description
This PR adds the FAB to the tab switcher. It is hidden under a feature flag, which must be enabled first.
This PR demonstrates the 2 states of the FAB that will be used later in the multi-selection -- "New Tab" & "Close Tabs". Clicking the button will not actually change this in the actual implementation.
Steps to test this PR
+icon is shown and the title is "New Tab"xand title says "Close Tabs"