Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show on App Launch: Use string resources for settings #5547

Conversation

mikescamell
Copy link
Contributor

@mikescamell mikescamell commented Jan 27, 2025

Task/Issue URL: https://app.asana.com/0/1202552961248957/1209246799465881/f

Description

Replaced hardcoded strings with string resources in the app launch settings screen for better localization support. Updated text references for "Last Opened Tab," "New Tab Page," and "Specific Page" options.

Steps to test this PR

String Resources Implementation

  • Navigate to Show on App launch settings
  • Verify "Last Opened Tab" displays correctly from string resources
  • Verify "New Tab Page" displays correctly from string resources
  • Verify "Specific Page" displays correctly from string resources
  • Test in different locales to ensure proper translation support

UI changes

Before After
Screenshot_20250127_160409 Screenshot_20250127_161411

Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@mikescamell mikescamell marked this pull request as ready for review January 27, 2025 16:15
Translate strings to values-es
Translate strings to values-ro
Translate strings to values-tr
Translate strings to values-sk
Translate strings to values-ru
Translate strings to values-et
Translate strings to values-it
Translate strings to values-pl
Translate strings to values-bg
Translate strings to values-lv
Translate strings to values-fi
Translate strings to values-sl
Translate strings to values-nl
Translate strings to values-hr
Translate strings to values-hu
Translate strings to values-nb
Translate strings to values-sv
Translate strings to values-da
Translate strings to values-el
Translate strings to values-fr
Translate strings to values-lt
Translate strings to values-pt
Translate strings to values-cs
Translate strings-subscriptions to values-hu
Translate strings-subscriptions to values-tr
Translate strings-subscriptions to values-de
Translate strings-subscriptions to values-lv
Translate strings-subscriptions to values-sv
Translate strings-subscriptions to values-pl
Translate strings-subscriptions to values-it
Translate strings-subscriptions to values-et
Translate strings-subscriptions to values-es
Translate strings-subscriptions to values-cs
Translate strings-subscriptions to values-da
Translate strings-subscriptions to values-ro
Translate strings-subscriptions to values-hr
Translate strings-subscriptions to values-el
Translate strings-subscriptions to values-nl
Translate strings-subscriptions to values-sk
Translate strings-subscriptions to values-sl
Translate strings-subscriptions to values-ru
Translate strings-subscriptions to values-fi
Translate strings-subscriptions to values-fr
Translate strings-subscriptions to values-lt
Translate strings-subscriptions to values-pt
Translate strings-subscriptions to values-bg
@mikescamell mikescamell changed the title Show on App Launch: Use translated strings for settings Show on App Launch: Use string resources for settings Jan 27, 2025
@mikescamell mikescamell deleted the feature/mike/show-on-app-launch/fix-missing-translations branch January 27, 2025 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants