Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show on App Launch: Use string resources for settings #5547

Closed
wants to merge 3 commits into from
Closed

Show on App Launch: Use string resources for settings #5547

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cca25b1
use translated strings for show on app launch
mikescamell Jan 27, 2025
278da0f
Translate strings to values-de
daxmobile Jan 27, 2025
7d946c7
Translate strings-subscriptions to values-nb
daxmobile Jan 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions app/src/main/res/layout/activity_show_on_app_launch_setting.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,21 +41,21 @@
android:layout_width="match_parent"
android:layout_height="wrap_content"
android:minHeight="@dimen/oneLineItemHeight"
app:primaryText="Last Opened Tab" />
app:primaryText="@string/showOnAppLaunchOptionLastOpenedTab" />

<com.duckduckgo.common.ui.view.listitem.RadioListItem
android:id="@+id/newTabCheckListItem"
android:layout_width="match_parent"
android:layout_height="wrap_content"
android:minHeight="@dimen/oneLineItemHeight"
app:primaryText="New Tab Page" />
app:primaryText="@string/showOnAppLaunchOptionNewTabPage" />

<com.duckduckgo.common.ui.view.listitem.RadioListItem
android:id="@+id/specificPageCheckListItem"
android:layout_width="match_parent"
android:layout_height="wrap_content"
android:minHeight="@dimen/oneLineItemHeight"
app:primaryText="Specific Page" />
app:primaryText="@string/showOnAppLaunchOptionSpecificPage" />

<com.duckduckgo.common.ui.view.text.DaxTextInput
android:id="@+id/specificPageUrlInput"
Expand Down
1 change: 1 addition & 0 deletions app/src/main/res/values-et/strings.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -792,4 +792,5 @@
<!-- DuckChat -->
<string name="duckChatTitle">Duck.ai</string>
<string name="duckChatMenuItem">Uus AI vestlus</string>

</resources>
2 changes: 1 addition & 1 deletion app/src/main/res/values-lt/strings.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,8 +132,8 @@
<string name="settingsAboutDuckduckgo">Apie „DuckDuckGo“</string>
<string name="settingsVersion">Versija</string>
<string name="leaveFeedback">Bendrinti atsiliepimą</string>
<string name="settingsEmailProtectionTitle">El. pašto apsauga</string>
<string name="leaveFeedbackNew">Siųsti atsiliepimą</string>
<string name="settingsEmailProtectionTitle">El. pašto apsauga</string>
<string name="settingsEmailProtectionSubtitle">Blokuokite el. laiškų sekimo priemones ir paslėpkite savo adresą</string>
<string name="settingsHeadingMore">Daugiau iš „DuckDuckGo“</string>
<string name="settingsHeadingNextSteps">Tolesni veiksmai</string>
Expand Down
6 changes: 3 additions & 3 deletions subscriptions/subscriptions-impl/src/main/res/values-pl/strings-subscriptions.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,9 +44,9 @@
<string name="subscriptionRemoved">Twoja subskrypcja została usunięta z tego urządzenia</string>
<string name="removeFromDevice">Usunąć z tego urządzenia?</string>
<string name="removeFromDeviceDescription">Nie będziesz już mieć dostępu do subskrypcji Privacy Pro na tym urządzeniu. Nie spowoduje to anulowania Twojej subskrypcji, która pozostanie aktywna na pozostałych urządzeniach.</string>
<string name="subscriptionsDataMonthly" instruction="First placeholder is renews or expires, second is a date in format MMMM dd, yyyy">Twoja miesięczna subskrypcja %1$s w dniu %2$s.</string>
<string name="subscriptionsDataYearly" instruction="First placeholder is renews or expires, second is a date in format MMMM dd, yyyy">Twoja roczna subskrypcja %1$s w dniu %2$s.</string>
<string name="subscriptionsExpiredData" instruction="The placeholder is a date in format MMMM dd, yyyy">Twoja subskrypcja wygasła w dniu %1$s.</string>
<string name="subscriptionsDataMonthly" instruction="First placeholder is renews or expires, second is a date in format MMMM dd, yyyy">Twoja miesięczna subskrypcja %1$s %2$s.</string>
<string name="subscriptionsDataYearly" instruction="First placeholder is renews or expires, second is a date in format MMMM dd, yyyy">Twoja roczna subskrypcja %1$s %2$s.</string>
<string name="subscriptionsExpiredData" instruction="The placeholder is a date in format MMMM dd, yyyy">Twoja subskrypcja wygasła %1$s.</string>
<string name="monthlySubscription">Subskrypcja miesięczna</string>
<string name="yearlySubscription">Subskrypcja roczna</string>
<string name="renews">zostaje odnowiona</string>
Expand Down
Loading