Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui): hide "renew dhcp lease" button #5639

Merged
merged 3 commits into from
Jan 9, 2025

Conversation

mattdibi
Copy link
Contributor

@mattdibi mattdibi commented Jan 9, 2025

This PR hides the "Renew DHCP lease" button from Kura web UI.


When we switched from the old Kura networking to NetworkManager we lost the ability to renew the DHCP lease. We investigated the possibility to add this functionality back in. The results are the following:

  1. There seems to be no "native" way to explicitly handle this in NetworkManager (for now) see Issue #1662.
  2. There are alternative methods but either they are not really a "renewal" of the DHCP lease (i.e. result in lost connection) or they are quite invasive (see here) and rely on specific configurations (i.e. dhclient as dhcp client which might not be always true).
  3. The real "DHCP lease renewal" should not lose the connection.

Given the above and the fact that the "Renew DHCP lease" functionality is not a hard requirement for our project, in agreement with @MMaiero, we decided to leave the feature out for now. When issue #1662 will be resolved we'll enable the feature back in.

To avoid confusion for our users we decided to hide the "Renew DHCP lease" button from Kura web UI, since it is currently non-functional. This is what this PR achieves.


Results:

image

@mattdibi mattdibi marked this pull request as ready for review January 9, 2025 09:29
@mattdibi mattdibi requested a review from MMaiero January 9, 2025 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants