feat(ui): hide "renew dhcp lease" button #5639
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR hides the "Renew DHCP lease" button from Kura web UI.
When we switched from the old Kura networking to NetworkManager we lost the ability to renew the DHCP lease. We investigated the possibility to add this functionality back in. The results are the following:
Given the above and the fact that the "Renew DHCP lease" functionality is not a hard requirement for our project, in agreement with @MMaiero, we decided to leave the feature out for now. When issue #1662 will be resolved we'll enable the feature back in.
To avoid confusion for our users we decided to hide the "Renew DHCP lease" button from Kura web UI, since it is currently non-functional. This is what this PR achieves.
Results: