Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui): hide "renew dhcp lease" button #5639

Merged
merged 3 commits into from
Jan 9, 2025
Merged

feat(ui): hide "renew dhcp lease" button #5639

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3d355b3
feat(ui): hide "renew DHCP lease" button
mattdibi Jan 9, 2025
2d66411
docs: ah-a! copyright header update
mattdibi Jan 9, 2025
25616a9
docs: reword comment
mattdibi Jan 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion .../org.eclipse.kura.web2/src/main/java/org/eclipse/kura/web/client/ui/network/TabIp4Ui.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*******************************************************************************
* Copyright (c) 2011, 2024 Eurotech and/or its affiliates and others
* Copyright (c) 2011, 2025 Eurotech and/or its affiliates and others
*
* This program and the accompanying materials are made
* available under the terms of the Eclipse Public License 2.0
Expand Down Expand Up @@ -469,6 +469,12 @@ public void onSuccess(Void result) {
});
});

// Currently the NetworkManager-based networking backend doesn't support
// renewing DHCP leases. Given this we decided to hide the "Renew DHCP lease"
// button since it's non-functional. This is a temporary solution until
// NetworkManager and our backend are updated to support this feature.
this.renew.setVisible(false);

this.renew.addMouseOverHandler(event -> {
if (TabIp4Ui.this.renew.isEnabled()) {
TabIp4Ui.this.helpText.clear();
Expand Down
Loading