Remove exception from ci #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MatthewKhouzam
force-pushed
the
remove-exception-from-ci
branch
from
d8fdd2d
to
d28a96b
Compare
MatthewKhouzam
force-pushed
the
remove-exception-from-ci
branch
3 times, most recently
from
9820014
to
ed60352
Compare
|
It finally works! LogManager was polluted from one test to another. |
It pollutes the console and makes debugging the build harder. Asserting can also make the failure mode testing more precise. Signed-off-by: Matthew Khouzam <[email protected]>
MatthewKhouzam
force-pushed
the
remove-exception-from-ci
branch
from
ed60352
to
27ef953
Compare
bhufmann
approved these changes
Mar 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.