Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: avoid integer abs in MatrixTransferStatic.cc and calorimetry_HEXPLIT.cc #1703

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

wdconinc
Copy link
Contributor

Briefly, what does this PR introduce?

abs without std results in using integer absolute value, which the compiler warns about:

warning: using integer absolute value function 'abs' when argument is of floating point type [-Wabsolute-value]

What kind of change does this PR introduce?

  • Bug fix (issue #__)
  • New feature (issue #__)
  • Documentation update
  • Other: __

Please check if this PR fulfills the following:

  • Tests for the changes have been added
  • Documentation has been added / updated
  • Changes have been communicated to collaborators

Does this PR introduce breaking changes? What changes might users need to make to their code?

No.

Does this PR change default behavior?

No.

@veprbl veprbl requested review from a team and rahmans1 and removed request for a team January 14, 2025 21:10
@github-actions github-actions bot added the topic: calorimetry relates to calorimetry label Jan 15, 2025
@wdconinc wdconinc changed the title fix: avoid integer abs in MatrixTransferStatic.cc fix: avoid integer abs in MatrixTransferStatic.cc and calorimetry_HEXPLIT.cc Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: calorimetry relates to calorimetry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant