-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CLI and library for extrinsics interaction #150
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you did a lot of evil magic! great work, let's iron out some intricacies and roll with it
I didn't run the code yet, will do that tomorrow -> wanna publish the findings of just reading the code for now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow. Good job figuring out the subxt 💪
-
I have a feeeling that at the end we might have a single cli endpoint for both provider and client. The
polka-storage-provider
might only be used for configuring and starting up the provider server and that is it. -
Run taplo fmt before taging the pr. It will fail currently.
-
Do you have an idea how should we version the motadata.scale?
We might, but the library at least was necessary and the current CLI is very cluttered already. Joining them later isn't too hard.
Honestly, no. We can just keep incrementing the name once someone makes a change, but since it's a binary blob it's really hard. The alternative is to codegen everything and check that in. |
`add_balance` and `withdraw_balance` are working
currently doesn't build, trying to figure out how to best handle some things
library now builds
Co-authored-by: Konrad Stepniak <[email protected]>
Co-authored-by: Konrad Stepniak <[email protected]>
Co-authored-by: Konrad Stepniak <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TREMENDOUSLY HUGE GREAT WORK!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice 💪 Great job!
Description
Fixes #130
I've ended up introducing a separate CLI as I thought it would be weird to join two very separate sides in a single binary. If the team disagrees, I can put it in a single place.
The binary itself should be discoverable as is, but just
--help
ing your way through.Testing with the scenarios for the integration tests would be great to ensure this is working.
I'm looking for feedback and questions!
Important points for reviewers
subxt is a weird beast, take a look into the docs while reading the PR.
Keep in mind that some types needed wrappers or similar because of conversions to bounded vecs and friends.
Checklist