Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(polka-storage-provider-server): implement config file #674

Merged
merged 2 commits into from
Jan 14, 2025
Merged

feat(polka-storage-provider-server): implement config file #674

merged 2 commits into from
Jan 14, 2025

Conversation

jmg-duarte
Copy link
Contributor

Description

Implements support for a config file (JSON or TOML)

Checklist

  • Make sure that you described what this change does.
  • Have you tested this solution?

@jmg-duarte jmg-duarte added the node-storage-provider Related to the storage provider node. label Jan 13, 2025
@jmg-duarte jmg-duarte added this to the Phase 3 milestone Jan 13, 2025
@jmg-duarte jmg-duarte self-assigned this Jan 13, 2025
@jmg-duarte jmg-duarte enabled auto-merge (squash) January 13, 2025 14:25
@jmg-duarte jmg-duarte added the ready for review Review is needed label Jan 13, 2025
cernicc
cernicc previously approved these changes Jan 13, 2025
View reviewed changes
Copy link
Member

@cernicc cernicc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jmg-duarte jmg-duarte requested a review from cernicc January 13, 2025 20:56
@jmg-duarte jmg-duarte added ready for review Review is needed and removed ready for review Review is needed labels Jan 13, 2025
aidan46
aidan46 reviewed Jan 14, 2025
View reviewed changes
examples/sp.config.json Outdated Show resolved Hide resolved
aidan46
aidan46 previously approved these changes Jan 14, 2025
View reviewed changes
Copy link
Contributor

@aidan46 aidan46 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍. Should we provide an example configuration for the storage provider?

cernicc
cernicc previously approved these changes Jan 14, 2025
View reviewed changes
@jmg-duarte jmg-duarte dismissed stale reviews from cernicc and aidan46 via 6b47b02 January 14, 2025 10:47
@jmg-duarte jmg-duarte added ready for review Review is needed and removed ready for review Review is needed labels Jan 14, 2025
@jmg-duarte jmg-duarte merged commit 498840d into develop Jan 14, 2025
5 checks passed
@jmg-duarte jmg-duarte deleted the feat/file-config branch January 14, 2025 11:35
@jmg-duarte jmg-duarte mentioned this pull request Jan 14, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aidan46 aidan46 aidan46 approved these changes

@cernicc cernicc cernicc approved these changes

@th7nder th7nder Awaiting requested review from th7nder

@pete-eiger pete-eiger Awaiting requested review from pete-eiger

Assignees

@jmg-duarte jmg-duarte

Labels
node-storage-provider Related to the storage provider node. ready for review Review is needed
Projects
None yet
Milestone
Phase 3
Development

Successfully merging this pull request may close these issues.
3 participants
@jmg-duarte @cernicc @aidan46