-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(pallet-market): implement activate_deals #96
Conversation
2b120ef
to
35a69f0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't find anything that was plain wrong, but I think there's space to make the overall structure easier to follow and check for vec bound bugs - i.e. no space to push.
Hope it's not too nitpicky, if it is, let me know!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Some grammar nazi comments left :D
fda6c6e
to
5ffeec7
Compare
88dc8c5
to
6242b9f
Compare
6242b9f
to
d8823d0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job 👍
Description
Activated Deal is a deal that's required to be verified in some time by Storage Provider Proofs, if not, Storage Provider will be slashed. This is more like a 'data storage' function, responsibility for calling that lies on the Storage Provider Pallet.
Important points for reviewers
Checklist