Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pallet-market): implement activate_deals #96

Merged
merged 9 commits into from
Jun 28, 2024

Conversation

th7nder
Copy link
Contributor

@th7nder th7nder commented Jun 24, 2024

Description

Activated Deal is a deal that's required to be verified in some time by Storage Provider Proofs, if not, Storage Provider will be slashed. This is more like a 'data storage' function, responsibility for calling that lies on the Storage Provider Pallet.

Important points for reviewers

Checklist

  • Are there important points that reviewers should know?
    • If yes, which ones?
  • Make sure that you described what this change does.
  • If there are follow-ups, have you created issues for them?
    • If yes, which ones? / List them here
  • Have you tested this solution?
  • Were there any alternative implementations considered?
  • Did you document new (or modified) APIs?

@th7nder th7nder force-pushed the feat/11/market-pallet-activate-deals branch from 2b120ef to 35a69f0 Compare June 25, 2024 06:55
@th7nder th7nder marked this pull request as ready for review June 25, 2024 07:03
@th7nder th7nder added the ready for review Review is needed label Jun 25, 2024
Copy link
Contributor

@jmg-duarte jmg-duarte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't find anything that was plain wrong, but I think there's space to make the overall structure easier to follow and check for vec bound bugs - i.e. no space to push.

Hope it's not too nitpicky, if it is, let me know!

primitives/proofs/src/traits.rs Outdated Show resolved Hide resolved
primitives/proofs/src/traits.rs Outdated Show resolved Hide resolved
pallets/market/src/test.rs Outdated Show resolved Hide resolved
pallets/market/src/lib.rs Outdated Show resolved Hide resolved
pallets/market/src/lib.rs Outdated Show resolved Hide resolved
pallets/market/src/lib.rs Outdated Show resolved Hide resolved
pallets/market/src/lib.rs Show resolved Hide resolved
pallets/market/src/lib.rs Outdated Show resolved Hide resolved
pallets/market/src/lib.rs Outdated Show resolved Hide resolved
Copy link
Member

@cernicc cernicc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Some grammar nazi comments left :D

pallets/market/src/lib.rs Outdated Show resolved Hide resolved
pallets/market/src/lib.rs Outdated Show resolved Hide resolved
primitives/proofs/src/traits.rs Show resolved Hide resolved
primitives/proofs/src/traits.rs Show resolved Hide resolved
pallets/market/src/lib.rs Outdated Show resolved Hide resolved
@th7nder th7nder force-pushed the feat/11/market-pallet-verify-deals branch from fda6c6e to 5ffeec7 Compare June 26, 2024 13:51
@th7nder th7nder force-pushed the feat/11/market-pallet-activate-deals branch from 88dc8c5 to 6242b9f Compare June 26, 2024 13:53
Base automatically changed from feat/11/market-pallet-verify-deals to develop June 28, 2024 05:01
@th7nder th7nder force-pushed the feat/11/market-pallet-activate-deals branch from 6242b9f to d8823d0 Compare June 28, 2024 05:10
@th7nder th7nder added ready for review Review is needed and removed ready for review Review is needed labels Jun 28, 2024
@th7nder th7nder requested review from jmg-duarte and cernicc June 28, 2024 05:12
@th7nder th7nder added ready for review Review is needed and removed ready for review Review is needed labels Jun 28, 2024
@th7nder th7nder added ready for review Review is needed and removed ready for review Review is needed labels Jun 28, 2024
Copy link
Member

@cernicc cernicc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job 👍

@th7nder th7nder merged commit 948bdc7 into develop Jun 28, 2024
3 checks passed
@th7nder th7nder deleted the feat/11/market-pallet-activate-deals branch June 28, 2024 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review Review is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants