Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor CI lint/notice steps improvement #3089

Merged
merged 10 commits into from
Jan 9, 2025
Merged

Conversation

artem-shelkovnikov
Copy link
Member

@artem-shelkovnikov artem-shelkovnikov commented Jan 9, 2025

  1. Fix is_pr function to properly tell if job is running on top of PR or not
  2. Add git diff to notice/lint stages for debugging

@artem-shelkovnikov artem-shelkovnikov changed the title change is_pr function condition Minor CI lint/notice steps improvement Jan 9, 2025
.buildkite/shared.sh Outdated Show resolved Hide resolved
seanstory
seanstory previously approved these changes Jan 9, 2025
Copy link
Member

@seanstory seanstory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We'll at least have more info if main keeps failing

@artem-shelkovnikov artem-shelkovnikov marked this pull request as ready for review January 9, 2025 16:35
@artem-shelkovnikov artem-shelkovnikov requested a review from a team as a code owner January 9, 2025 16:35
@artem-shelkovnikov artem-shelkovnikov merged commit c664243 into main Jan 9, 2025
2 checks passed
@artem-shelkovnikov artem-shelkovnikov deleted the artem/update-is-pr branch January 9, 2025 16:49
Copy link

github-actions bot commented Jan 9, 2025

💔 Failed to create backport PR(s)

The backport operation could not be completed due to the following error:
There are no branches to backport to. Aborting.

The backport PRs will be merged automatically after passing CI.

To backport manually run:
backport --pr 3089 --autoMerge --autoMergeMethod squash

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants