Tests : ajout de PHPStan #662
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raphodn
changed the base branch from
master
to
raphodn/test-ci-github-actions
raphodn
force-pushed
the
raphodn/test-add-phpstan
branch
from
858c0bd to
b407950
Compare
2 tasks
raphodn
force-pushed
the
raphodn/test-add-phpstan
branch
2 times, most recently
from
701cf47 to
4e84d2c
Compare
raphodn
force-pushed
the
raphodn/test-add-phpstan
branch
from
e95e13d to
7ec2aa6
Compare
Closed
petitalb
reviewed
Jan 4, 2023
| } | ||
|
|
There was a problem hiding this comment.
supprimer ce code mort plutot ?
There was a problem hiding this comment.
j'étais allé un peu vite en besogne je trouve, j'ai modifié pour éviter de supprimer ce bout de code : a9878dc
petitalb
approved these changes
Jan 4, 2023
raphodn
commented
Jan 4, 2023
| * | ||
| * @return \DateTime | ||
| */ | ||
| public function getMinDateOfLastRegistration() |
There was a problem hiding this comment.
@petitalb merci pour le fix. du coup pas possible de récupérer les paramètres dans une Entity ?
There was a problem hiding this comment.
Il me semble que ce n'est pas possible effectivement. Faut passer par un service.
Note, ce code n'était de toute façon pas utilisé, je l'avais déjà remarqué dans ma PR #698.
|
les tests PHPStan passent 🎉 |
quot17
pushed a commit
to quot17/gestion-compte
that referenced
this pull request
Mar 28, 2023
* Add PHPStan package. run in CI * Fix errors from Entities & Controllers * fix errors in BookingController * remove useless from EntityService * remove useless from CommissionJoinOrLeaveEvent * ToggleableHandler: handle() should return bool * fix BeneficiaryService & MembershipService * fix ShiftService * fix SwipeCardEvent & TimeLogEventListener * fix BasePathPicture * fix Commands * Remove unused code * homogenise form error display Co-authored-by: Albin PETIT <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Voir l'issue #699
Suite de #661
Pour lancer la commande en local (après avoir fait un
composer install)