-
Notifications
You must be signed in to change notification settings - Fork 336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Wavlm models #2219
base: maeb
Are you sure you want to change the base?
Added Wavlm models #2219
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good start!
device: str | None = None, | ||
model_name: str = "microsoft/wavlm-base", | ||
model_revision: str = "", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
device: str | None = None, | |
model_name: str = "microsoft/wavlm-base", | |
model_revision: str = "", | |
model_name: str, | |
model_revision: str, | |
device: str | None = None, |
use_instructions=False, | ||
public_training_code=None, | ||
public_training_data=None, | ||
training_datasets=None, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add annotation of training_datasets?
Addressing Issue: #2218
Code Quality
make lint
to maintain consistent style.Documentation
Testing
make test-with-coverage
.make test
ormake test-with-coverage
to ensure no existing functionality is broken.Adding a model checklist
mteb.get_model(model_name, revision)
andmteb.get_model_meta(model_name, revision)
Added the following models:
Command