Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

postgres: use wait_for in disconnect #97

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

postgres: use wait_for in disconnect #97

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7685960
postgres: use wait_for in disconnect
blueyed May 7, 2019
406184e
Merge branch 'master' into wait_for
tomchristie Apr 29, 2020
8cb5c01
Merge branch 'master' into wait_for
blueyed Jun 4, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion databases/backends/postgres.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
import asyncio
import logging
import typing
from collections.abc import Mapping
Expand Down Expand Up @@ -66,7 +67,7 @@ async def connect(self) -> None:

async def disconnect(self) -> None:
assert self._pool is not None, "DatabaseBackend is not running"
await self._pool.close()
await asyncio.wait_for(self._pool.close(), timeout=30)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As @tomchristie wrote, it is a good idea to make the timeout configurable, otherwise, 30 seconds can be too much for everybody.

self._pool = None

def connection(self) -> "PostgresConnection":
Expand Down