Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move reporter binding to service provider #12

Merged
merged 3 commits into from
Apr 17, 2017
Merged

Move reporter binding to service provider #12

merged 3 commits into from
Apr 17, 2017

Conversation

esbenp
Copy link
Owner

@esbenp esbenp commented Apr 17, 2017

Laravel removed parameters from the container make command. The
reporters can therefore not be instantiated since the config is not
passed by the container. See more here
laravel/ideas#391
We now fix this by binding the reporters in the service provider
instead.

Closes #8

Laravel removed parameters from the container make command. The
reporters can therefore not be instantiated since the config is not
passed by the container. See more here
laravel/ideas#391
We now fix this by binding the reporters in the service provider
instead.

Closes #8
@coveralls
Copy link

Coverage Status

Coverage decreased (-8.3%) to 51.449% when pulling 1c68bc8 on fix-8 into 7e4f09e on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-6.1%) to 53.623% when pulling 894cd01 on fix-8 into 7e4f09e on master.

@coveralls
Copy link

coveralls commented Apr 17, 2017

Coverage Status

Coverage decreased (-0.6%) to 59.146% when pulling 4b91ab2 on fix-8 into 7e4f09e on master.

@esbenp esbenp merged commit eda2d19 into master Apr 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: SentryReporter cannot be Instanciated
2 participants