Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(observability): network label for supervisor #187

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -146,6 +146,10 @@ optimism_package:
# A list of optional extra params that will be passed to the supervisor container for modifying its behaviour
extra_params: []

# Network name, used to enable syncing of alternative networks
# Defaults to "kurtosis"
network: "kurtosis"

# AltDA Deploy Configuration, which is passed to op-deployer.
#
# For simplicity we currently enforce chains to all be altda or all rollups.
Expand Down
2 changes: 1 addition & 1 deletion src/interop/op-supervisor/op_supervisor_launcher.star
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ def launch(
)

observability.register_op_service_metrics_job(
observability_helper, supervisor_service
observability_helper, supervisor_service, supervisor_params.network
)

return "op_supervisor"
Expand Down
2 changes: 2 additions & 0 deletions src/package_io/input_parser.star
Original file line number Diff line number Diff line change
Expand Up @@ -123,6 +123,7 @@ def input_parser(plan, input_args):
"dependency_set"
],
extra_params=results["interop"]["supervisor_params"]["extra_params"],
network=results["interop"]["supervisor_params"]["network"],
),
),
altda_deploy_config=struct(
Expand Down Expand Up @@ -515,6 +516,7 @@ def default_supervisor_params():
"image": DEFAULT_SUPERVISOR_IMAGES["op-supervisor"],
"dependency_set": "",
"extra_params": [],
"network": constants.NETWORK_NAME,
}


Expand Down
1 change: 1 addition & 0 deletions src/package_io/sanity_check.star
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,7 @@ SUPERVISOR_PARAMS = [
"image",
"dependency_set",
"extra_params",
"network",
]

ALTDA_DEPLOY_CONFIG_PARAMS = [
Expand Down
Loading