Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(observability): network label for supervisor #187

Merged
merged 1 commit into from
Mar 7, 2025
Merged

fix(observability): network label for supervisor #187

merged 1 commit into from
Mar 7, 2025

Conversation

pcw109550
Copy link
Contributor

Missed to add network param for supervisor at #185.

Dodges below error when interop is enabled.

: interpretation error: Evaluation error: function register_op_service_metrics_job missing 1 argument (network_name)
        at [github.com/ethpandaops/optimism-package/main.star:130:38]: run
        at [github.com/ethpandaops/optimism-package/src/interop/op-supervisor/op_supervisor_launcher.star:79:50]: launch
        at [github.com/ethpandaops/optimism-package/src/observability/observability.star:87:5]: register_op_service_metrics_job

@pcw109550 pcw109550 mentioned this pull request Mar 7, 2025
Merged
@sigma sigma enabled auto-merge (squash) March 7, 2025 13:19
@sigma sigma merged commit 884f4eb into ethpandaops:main Mar 7, 2025
6 checks passed
@EthPandaOpsBot EthPandaOpsBot mentioned this pull request Mar 7, 2025
Open
@edobry edobry mentioned this pull request Mar 7, 2025
Merged
sigma pushed a commit that referenced this pull request Mar 10, 2025
@edobry
fix(observability): remove supervisor network label (#190)
bb4a36d 
This PR follows up on the fix made in
#187 to make the
network label optional, as `op-supervisor`is an interop component and
hence not specific to any one network.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sigma sigma sigma approved these changes

@scharissis scharissis scharissis approved these changes

@protolambda protolambda protolambda approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pcw109550 @sigma @scharissis @protolambda