feat: use pkgjs/meet to generate meeting agenda #206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
wesleytodd
force-pushed
the
meetings
branch
7 times, most recently
from
f177e62 to
ad9c12d
Compare
|
Ok, fixed the template but now it is creating a new issue even though it is supposed to be updating the existing one. Next fix in the works. Sorry for the noise. |
wesleytodd
force-pushed
the
meetings
branch
2 times, most recently
from
a8b0fa4 to
06ae258
Compare
UlisesGascon
reviewed
Mar 4, 2024
jonchurch
approved these changes
Mar 5, 2024
| issueTitle: '<%= date.toFormat("yyyy-MM-dd") %> Express TC Meeting' | ||
| token: ${{ secrets.GITHUB_TOKEN }} | ||
| orgs: expressjs,pillarjs,jshttp | ||
| agendaLabel: 'top priority' |
There was a problem hiding this comment.
I'd expect this to be agenda or an array that allows ['top-priority', 'agenda']
Adding an agenda label is the convention I'd expect. Easy to slap an agenda label on something to know it will show up in the meeting. Not everything to be discussed is always going to be "top priority".
There was a problem hiding this comment.
Yeah I only used this to start because it was preexisting. We can go through all of them and add a better label for future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added support in
pkgjs/meetfor generating meeting agendas. I hope this works well, I tested in a personal repo and it seems to. We will want to edit the template and stuff with the right links but I wanted to make sure this was all working first.