FR-613 Add Rails 7.2 support #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aisayo
force-pushed
the
add-support-for-rails-7-2
branch
2 times, most recently
from
a5b7554 to
d063b91
Compare
Make sure you read the updgrade to [Device 4.9.0 documentation](https://github.com/heartcombo/devise/wiki/How-To:-Upgrade-to-Devise-4.9.0-%5BHotwire-Turbo-integration%5D) References: * https://github.com/heartcombo/devise/blob/4-stable/CHANGELOG.md#490---2023-02-17 Ticket: https://ombulabs.atlassian.net/browse/FR-613
JuanVqz
force-pushed
the
add-support-for-rails-7-2
branch
from
d063b91 to
58b4a9b
Compare
|
Let's make sure we read the device upgrade guide |
JuanVqz
force-pushed
the
add-support-for-rails-7-2
branch
3 times, most recently
from
be3f2ca to
4dbd925
Compare
JuanVqz
force-pushed
the
add-support-for-rails-7-2
branch
from
4dbd925 to
1c55263
Compare
we should be able to run the test suite without issues, Adding a CI workflows to ensure it is working. Ticket: https://ombulabs.atlassian.net/browse/FR-613
JuanVqz
force-pushed
the
add-support-for-rails-7-2
branch
from
1c55263 to
f8c9652
Compare
|
@etagwerker I can release it, if you provide enough permissions to my RubyGems account 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our main goal is to add the following:
Additionally, because we have time:
Fixes #23