Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FR-613 Add Rails 7.2 support #24

Merged
merged 3 commits into from
Feb 10, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 27 additions & 0 deletions .github/workflows/tests.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
name: Tests

on:
push:
branches: [ '**' ]

jobs:
test:
runs-on: ubuntu-latest
strategy:
matrix:
ruby-version: ['3.2', '3.1', '3.0']

steps:
- uses: actions/checkout@v3

- name: Set up Ruby
uses: ruby/setup-ruby@v1
with:
ruby-version: ${{ matrix.ruby-version }}
bundler-cache: true

- name: Install dependencies
run: bundle install

- name: Run tests
run: bundle exec rake
3 changes: 2 additions & 1 deletion .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -6,4 +6,5 @@
/test/dummy/log/*.log
/test/dummy/storage/
/test/dummy/tmp/
Gemfile.lock
/test/dummy/dummy_test*
Gemfile.lock
2 changes: 1 addition & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## main [(unreleased)](https://github.com/fastruby/ombu_labs-auth/compare/6efa57eda3bd3f93e0f245342eb2a317574c32ff...main)

* [BUGFIX: Resolve Github Omniauth dependency](https://github.com/fastruby/ombu_labs-auth/pull/19)
* [FEATURE: Add Rails 7.2 compatibility](https://github.com/fastruby/ombu_labs-auth/pull/24)

## 1.0.0 (2023-06-09)

Expand Down
9 changes: 9 additions & 0 deletions Rakefile
Original file line number Diff line number Diff line change
Expand Up @@ -6,3 +6,12 @@ load "rails/tasks/engine.rake"
load "rails/tasks/statistics.rake"

require "bundler/gem_tasks"

require 'rake/testtask'

Rake::TestTask.new(:test) do |t|
t.libs << 'test'
t.pattern = 'test/**/*_test.rb'
end

task default: :test
2 changes: 1 addition & 1 deletion lib/ombu_labs/auth/version.rb
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
module OmbuLabs
module Auth
VERSION = "1.0.0"
VERSION = "1.1.0"
end
end
4 changes: 2 additions & 2 deletions ombu_labs-auth.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,8 @@ Gem::Specification.new do |spec|
Dir["{app,config,db,lib}/**/*", "MIT-LICENSE", "Rakefile", "README.md"]
end

spec.add_dependency "rails", ">= 6.0"
spec.add_dependency "devise", "~> 4.8.1"
spec.add_dependency "rails", ">= 6.0", "< 7.3"
spec.add_dependency "devise", "~> 4.9"
spec.add_dependency "omniauth", "~> 2.1.0"
spec.add_dependency "omniauth-github", "~> 2.0.0"
spec.add_dependency "omniauth-rails_csrf_protection"
Expand Down
4 changes: 3 additions & 1 deletion test/controllers/callbacks_controller_test.rb
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
require "test_helper"

class CallbacksControllerTest < ActionDispatch::IntegrationTest
GITHUB_INFO = {
"id" => "12345",
Expand Down Expand Up @@ -67,4 +69,4 @@ def organization_members
assert_equal "This application is only available to members of my_org.", flash[:error]
end
end
end
end
3 changes: 3 additions & 0 deletions test/dummy/config/environments/test.rb
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,9 @@
# Raises error for missing translations.
# config.i18n.raise_on_missing_translations = true

# Allow any host in the test environment
config.hosts.clear

# Annotate rendered view with file names.
# config.action_view.annotate_rendered_view_with_filenames = true
end
Binary file removed test/dummy/dummy_development
Binary file not shown.
Empty file removed test/dummy/dummy_test
Empty file.