-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Traces type consolidation #180
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephlow
force-pushed
the
type-consolidation
branch
from
August 27, 2024 14:41
8651af2
to
dd3b454
Compare
commit: |
hatchan
approved these changes
Sep 5, 2024
keturiosakys
approved these changes
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The rust and ts apis where quite a bit different in handling traces / spans, which made it hard to make the ingestion engine compatible without a lot of effort.
This PR aims to unify the rust api and the ts api by trimming down the unnesecerry stuff from both sides and consolidate the api's, both with their native impls, as it's currently the case
original slack discussion
ts
raw_payload
fieldparsed_payload
toinner
inner
(prev.parsed_payload
)packages/types
rust
/api/traces
->/v1/traces
AttributeMap
compatible with the ts apiTraceSummary
to reflect the ts api