Bump graphql-simple-bindings-to-latest-greatest #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZzAve
force-pushed
the
bump-graphql-simple-bindings
branch
from
9f65b68 to
697ce50
Compare
added 2 commits
January 19, 2024 15:02
ZzAve
force-pushed
the
bump-graphql-simple-bindings
branch
from
721cfd8 to
6bb6d85
Compare
ZzAve
commented
Jan 20, 2024
| java-version: 11 | ||
| java-version: 17 |
There was a problem hiding this comment.
Bump java to java 17. The graphql-simple-bindings dependency is built with java 17.
ZzAve
commented
Jan 20, 2024
Comment on lines
-524
to
-558
| <repository> | ||
| <id>jfrog-flock-community</id> | ||
| <name>jfrog-repositories</name> | ||
| <url>https://flock.jfrog.io/artifactory/flock-maven</url> | ||
| <snapshots> | ||
| <enabled>false</enabled> | ||
| </snapshots> | ||
| </repository> | ||
| </repositories> | ||
|
|
||
| <pluginRepositories> | ||
| <pluginRepository> | ||
| <snapshots> | ||
| <enabled>false</enabled> | ||
| </snapshots> | ||
| <id>jfrog-flock-community</id> | ||
| <name>jfrog-plugins</name> | ||
| <url>https://flock.jfrog.io/artifactory/flock-maven</url> | ||
| </pluginRepository> | ||
| </pluginRepositories> | ||
|
|
||
|
|
||
| <distributionManagement> | ||
| <repository> | ||
| <id>jfrog-flock-community</id> | ||
| <name>jfrog-repo-releases</name> | ||
| <url>https://flock.jfrog.io/artifactory/flock-maven</url> | ||
| </repository> | ||
| <snapshotRepository> | ||
| <id>jfrog-flock-community</id> | ||
| <name>jfrog-repo-snapshots</name> | ||
| <url>https://flock.jfrog.io/artifactory/flock-maven</url> | ||
| </snapshotRepository> | ||
| </distributionManagement> | ||
|
|
There was a problem hiding this comment.
Boyscouting, removing all jfrog references as packages are published to maven central
ZzAve
commented
Jan 20, 2024
| @@ -335,7 +335,7 @@ | |||
| <plugin> | |||
| <groupId>community.flock</groupId> | |||
| <artifactId>graphql-simple-bindings-maven-plugin</artifactId> | |||
| <version>0.6.1</version> | |||
| <version>0.8.0</version> | |||
There was a problem hiding this comment.
With graphql-simple-bindings-maven-plugin version 0.8.0 the package name is suffixed with a .kotlin package. As a result all references to classes generated by the plugin had their import changed.
-import community.flock.eco.iso.language.graphql.Language
+import community.flock.eco.iso.language.graphql.kotlin.Language
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.