Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade ktlint-maven-plugin to 3.0.0 (bumps ktlint from 0.39.0 to 1.0.0 #96

Merged
merged 3 commits into from
Jan 20, 2024

Conversation

ZzAve
Copy link
Collaborator

@ZzAve ZzAve commented Jan 19, 2024

Improved ktlint handling:

  • runs at verify phase (instead of compile)
  • at default, only performs check
  • format can be run with mvn ktlint:format@ktlint-format
  • want to skip ktlint (and other quality steps)?: use -Dquality.skip

Julius van Dis added 2 commits January 19, 2024 15:57
Improved ktlint handling:

- runs at `verify` phase (instead of compile)
- at default, only performs `check`
- format can be run with `mvn ktlint:format@ktlint-format`
- want to skip ktlint (and other quality steps)?: use `-Dquality.skip`
Happy ktlint, happy flock?
Copy link
Collaborator

@jerrevanveluw jerrevanveluw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@wilmveel wilmveel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dikke PR!!!

@ZzAve
Copy link
Collaborator Author

ZzAve commented Jan 20, 2024

please merge #94 before this one

@wilmveel wilmveel merged commit 4a11c1c into bump-graphql-simple-bindings Jan 20, 2024
@ZzAve ZzAve deleted the ktlint-fix branch January 20, 2024 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants