-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UIROLES-112: create permissions for CRUD operations #88
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code changes LGTM. Please add a CHANGELOG entry and tweak the displayName
values. I realize those are ont used for anything ATM, but maybe they will in the future, or be used as the root for translation values.
package.json
Outdated
}, | ||
{ | ||
"permissionName": "ui-authorization-roles.settings.delete", | ||
"displayName": "Settings (Authorization roles): Can delete authorization role", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can delete authorization roles
^
package.json
Outdated
}, | ||
{ | ||
"permissionName": "ui-authorization-roles.settings.create", | ||
"displayName": "Settings (Authorization roles): Can create authorization role", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can create authorization roles
^
package.json
Outdated
}, | ||
{ | ||
"permissionName": "ui-authorization-roles.settings.edit", | ||
"displayName": "Settings (Authorization roles): Can edit authorization role", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can edit authorization roles
^
Quality Gate passedIssues Measures |
Refs UIROLES-112.