Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UIROLES-112: create permissions for CRUD operations #88

Merged
merged 4 commits into from
Nov 22, 2024
Merged

Conversation

aidynoJ
Copy link
Contributor

@aidynoJ aidynoJ commented Nov 19, 2024

Refs UIROLES-112.

Copy link

github-actions bot commented Nov 19, 2024

Jest Unit Test Results

1 files  ±0  2 suites  ±0   21s ⏱️ +9s
7 tests ±0  7 ✅ ±0  0 💤 ±0  0 ❌ ±0 
8 runs  ±0  8 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 159be17. ± Comparison against base commit 9712a52.

♻️ This comment has been updated with latest results.

@aidynoJ aidynoJ marked this pull request as ready for review November 20, 2024 12:18
@aidynoJ aidynoJ requested review from zburke and ryandberger and removed request for zburke November 20, 2024 12:18
Copy link
Member

@zburke zburke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes LGTM. Please add a CHANGELOG entry and tweak the displayName values. I realize those are ont used for anything ATM, but maybe they will in the future, or be used as the root for translation values.

package.json Outdated
},
{
"permissionName": "ui-authorization-roles.settings.delete",
"displayName": "Settings (Authorization roles): Can delete authorization role",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can delete authorization roles
                             ^

package.json Outdated
},
{
"permissionName": "ui-authorization-roles.settings.create",
"displayName": "Settings (Authorization roles): Can create authorization role",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can create authorization roles
                             ^

package.json Outdated
},
{
"permissionName": "ui-authorization-roles.settings.edit",
"displayName": "Settings (Authorization roles): Can edit authorization role",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can edit authorization roles
                           ^

@aidynoJ aidynoJ merged commit 012f1bf into master Nov 22, 2024
15 checks passed
@aidynoJ aidynoJ deleted the UIROLES-112 branch November 22, 2024 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants