Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UIROLES-112: create permissions for CRUD operations #88

Merged
merged 4 commits into from
Nov 22, 2024
Merged
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
65 changes: 52 additions & 13 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -57,33 +57,72 @@
"permissionName": "ui-authorization-roles.settings.admin",
"displayName": "Settings (Authorization roles): Can manage authorization roles",
"description": "",
"subPermissions": [
"ui-authorization-roles.settings.create",
"ui-authorization-roles.settings.view",
"ui-authorization-roles.settings.edit",
"ui-authorization-roles.settings.delete"
],
"visible": true
},
{
"permissionName": "ui-authorization-roles.settings.view",
"displayName": "Settings (Authorization roles): Can view authorization role details",
"description": "",
"subPermissions": [
"settings.authorization-roles.enabled",
"roles.item.get",
"roles.item.put",
"roles.item.delete",
"roles.item.post",
"roles.collection.get",
"roles.collection.post",
"roles.users.item.get",
"roles.users.item.put",
"roles.users.item.delete",
"roles.users.item.post",
"roles.users.collection.get",
"role-capabilities.collection.get",
"role-capabilities.collection.put",
"role-capabilities.collection.post",
"role-capabilities.collection.delete",
"role-capability-sets.collection.get",
"role-capability-sets.collection.put",
"role-capability-sets.collection.post",
"role-capability-sets.collection.delete",
"capabilities.collection.get",
"capability-sets.capabilities.collection.get",
"capability-sets.collection.get",
"users.collection.get"
],
"visible": true
},
{
"permissionName": "ui-authorization-roles.settings.delete",
"displayName": "Settings (Authorization roles): Can delete authorization role",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can delete authorization roles
                             ^

"description": "",
"subPermissions": [
"ui-authorization-roles.settings.view",
"roles.item.delete",
"roles.users.item.delete",
"role-capabilities.collection.delete",
"role-capability-sets.collection.delete"
],
"visible": true
},
{
"permissionName": "ui-authorization-roles.settings.create",
"displayName": "Settings (Authorization roles): Can create authorization role",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can create authorization roles
                             ^

"description": "",
"subPermissions": [
"ui-authorization-roles.settings.view",
"roles.item.post",
"roles.collection.post",
"roles.users.item.post",
"role-capabilities.collection.post",
"role-capability-sets.collection.post"
],
"visible": true
},
{
"permissionName": "ui-authorization-roles.settings.edit",
"displayName": "Settings (Authorization roles): Can edit authorization role",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can edit authorization roles
                           ^

"description": "",
"subPermissions": [
"ui-authorization-roles.settings.view",
"roles.item.put",
"roles.users.item.put",
"role-capabilities.collection.put",
"role-capability-sets.collection.put"
],
"visible": true
}
]
},
Expand Down
18 changes: 16 additions & 2 deletions src/index.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import { useIntlKeyStore } from '@k-int/stripes-kint-components';
import { Switch, Route, BrowserRouter as Router } from 'react-router-dom';
import PropTypes from 'prop-types';
import { IfPermission } from '@folio/stripes/core';

import {
RoleCreate,
Expand All @@ -16,8 +17,21 @@ const App = ({ match: { path } }) => {
return (
<Router>
<Switch>
<Route exact path={`${path}/create`} render={() => <RoleCreate path={path} />} />
<Route exact path={`${path}/:id/edit`} render={() => <RoleEdit path={path} />} />
<Route
exact
path={`${path}/create`}
render={() => <IfPermission perm="ui-authorization-roles.settings.create">
<RoleCreate path={path} />
</IfPermission>
}
/>
<Route
exact
path={`${path}/:id/edit`}
render={() => <IfPermission perm="ui-authorization-roles.settings.edit">
<RoleEdit path={path} />
</IfPermission>}
/>
<Route path={`${path}/:id?`} render={() => <Settings path={path} />} />
</Switch>
</Router>
Expand Down
23 changes: 14 additions & 9 deletions src/settings/SettingsPage/SettingsPage.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import PropTypes from 'prop-types';
import { useMemo, useState } from 'react';
import { useParams, useHistory } from 'react-router-dom';
import { IfPermission } from '@folio/stripes/core';

import { FormattedMessage, FormattedDate } from 'react-intl';

Expand Down Expand Up @@ -68,15 +69,17 @@ const SettingsPage = ({ path }) => {
};

const lastMenu = (
<PaneMenu>
<Button
to={`${path}/create`}
buttonStyle="primary"
marginBottom0
>
+ <FormattedMessage id="ui-authorization-roles.new" />
</Button>
</PaneMenu>
<IfPermission perm="ui-authorization-roles.settings.create">
<PaneMenu>
<Button
to={`${path}/create`}
buttonStyle="primary"
marginBottom0
>
+ <FormattedMessage id="ui-authorization-roles.new" />
</Button>
</PaneMenu>
</IfPermission>
);

const handleSearchSubmit = (event) => {
Expand Down Expand Up @@ -133,12 +136,14 @@ const SettingsPage = ({ path }) => {
/>
</Pane>
{roleId && (
<IfPermission perm="ui-authorization-roles.settings.view">
<RoleDetails
isLoading={isDuplicating}
onDuplicate={onDuplicate}
path={path}
roleId={roleId}
/>
</IfPermission>
)}
</Paneset>
);
Expand Down