UIBULKED-605 Enabling Confirm changes button based on forms state #679
Conversation
vashjs
changed the title
| const isAdministrativeFormPristine = !isEqual(ADMINISTRATIVE_FORM_INITIAL_STATE, contentUpdates); | ||
| const isMarcFormPristine = !isEqual(MARC_FORM_INITIAL_STATE, marcContentUpdatesWithoutId); | ||
|
|
||
| // state is valid if at least one form is filled and valid and another one is not pristine or both forms are filled and valid |
There was a problem hiding this comment.
I think you meant to say in the comment that another one is pristine
There was a problem hiding this comment.
I'm with @BogdanDenis here, but I feel like both the comment AND the conditional contradict the PR description which states "2 valid forms, or 1 valid and one untouched". Here, you instead check 2 valid forms or 1 valid and one NOT pristine. Or do you have the booleans on lines 57 and 58 configured backwards, i.e. isPristine should be true when those values are equal, instead of when they differ?
Super petty: since your comment describes two different scenarios, just put them on two different lines. As-is, it's hard to parse how the ands and ors separate things.
| const isAdministrativeFormPristine = !isEqual(ADMINISTRATIVE_FORM_INITIAL_STATE, contentUpdates); | ||
| const isMarcFormPristine = !isEqual(MARC_FORM_INITIAL_STATE, marcContentUpdatesWithoutId); | ||
|
|
||
| // state is valid if at least one form is filled and valid and another one is not pristine or both forms are filled and valid |
There was a problem hiding this comment.
I'm with @BogdanDenis here, but I feel like both the comment AND the conditional contradict the PR description which states "2 valid forms, or 1 valid and one untouched". Here, you instead check 2 valid forms or 1 valid and one NOT pristine. Or do you have the booleans on lines 57 and 58 configured backwards, i.e. isPristine should be true when those values are equal, instead of when they differ?
Super petty: since your comment describes two different scenarios, just put them on two different lines. As-is, it's hard to parse how the ands and ors separate things.
# Conflicts: # CHANGELOG.md
|
@zburke @BogdanDenis the variables actually had unnecessary inversions of values. I updated the PR description, and divided the variables into more meaningful parts. Please double check. |
src/components/BulkEditPane/BulkEditMarcLayer/BulkEditMarcLayer.js
Outdated
Show resolved
Hide resolved
|
Based on the new requirements, it is necessary to activate/deactivate the "Confirm changes" button based on the state of the forms.
Previously, a scenario was possible in which the user filled out one of the forms completely, and one partially. In this situation, the frontend made it possible to submit forms, but cut off partially filled forms and send default values.
After this PR is merged, the "Confirm changes" button will be enabled only in 3 cases:
Details:
Refs: UIBULKED-605