-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement DialogOverlay
and new ToastProvider
#101
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DialogOverlay
DialogOverlay
and new ToastProvider
nighto
reviewed
Jan 17, 2025
src/components/overlays/DialogOverlay/DialogOverlay.module.scss
Outdated
Show resolved
Hide resolved
nighto
reviewed
Jan 17, 2025
nighto
reviewed
Jan 17, 2025
src/components/overlays/ToastProvider/ToastProvider.module.scss
Outdated
Show resolved
Hide resolved
nighto
reviewed
Jan 17, 2025
nighto
reviewed
Jan 17, 2025
nighto
reviewed
Jan 17, 2025
nighto
reviewed
Jan 17, 2025
nighto
reviewed
Jan 17, 2025
nighto
approved these changes
Jan 17, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
DialogOverlay
component, which is similar toDialogModal
but is a non-modal component. Can be used for dialogs where the background UI should still be interactive. For example, a slide overlay where the user can still open up other items on screen.react-toastify
dependency (due to this issue) and replaced it with a custom toast notification system.ToastProvider
will be automatically portaled to the top-most modal/popover.TODO:
createPortal()
targets so that toast notifications don't render below popovers.ModalDialogProvider
(React context provider with frequentsetState
).DialogOverlay
(including one with toast notifications).subject
inuseWithSubject
hooks after overlay has unmounted. (EDIT: split out to *withState() hooks should clear subject state when no longer used #112)