Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement DialogOverlay and new ToastProvider #101

Merged
merged 32 commits into from
Jan 20, 2025
Merged
Show file tree
Hide file tree
Changes from 25 commits
Commits
Show all changes
32 commits
Select commit Hold shift + click to select a range
3522da6
Fix DialogModal rendering issues.
mkrause Jan 7, 2025
0f95430
Add DialogOverlay component.
mkrause Jan 8, 2025
c564519
Implement basic DialogOverlay.
mkrause Jan 8, 2025
6d02ea3
Experiment: sonner.
mkrause Jan 9, 2025
bdcaa31
Implement workaround to get react-toastify toast notifications workin…
mkrause Jan 10, 2025
57a448e
Merge branch 'master' into mkrause/250105-overlays
mkrause Jan 10, 2025
2847716
Refactor overlay utils: move to src/components/util/overlays.
mkrause Jan 12, 2025
702764a
Experiment: ToastContainer.
mkrause Jan 12, 2025
a6e9020
Refactor ToastProvider.
mkrause Jan 13, 2025
529fa67
Work on ToastProvider.
mkrause Jan 14, 2025
4cc0c5e
Update autoCloseTime.
mkrause Jan 14, 2025
c7270a9
Finalize ToastProvider and remove old Toast components.
mkrause Jan 14, 2025
78623c7
Add DialogOverlay to exports.
mkrause Jan 14, 2025
ec0d16f
Add @rollup/rollup-linux-x64-gnu as optional dependency to resolve CI…
mkrause Jan 14, 2025
9f2e143
Merge branch 'master' into mkrause/250105-overlays
mkrause Jan 14, 2025
9df7e90
Merge branch 'master' into mkrause/250105-overlays
mkrause Jan 14, 2025
935e9ab
Make CI happy.
mkrause Jan 14, 2025
914baa5
Add missing license header.
mkrause Jan 15, 2025
d13e240
Add DialogOverlay story to show toast notification inside a popover.
mkrause Jan 15, 2025
c6702c2
Keep toast notifications in the top layer even when other popovers open.
mkrause Jan 15, 2025
64a5374
Cleanup.
mkrause Jan 15, 2025
90aa6ab
DialogOverlay: remove full-screen and centered options.
mkrause Jan 16, 2025
ce4dcfb
Merge branch 'master' into mkrause/250105-overlays
mkrause Jan 16, 2025
c0d6dc6
Merge branch 'master' into mkrause/250105-overlays
mkrause Jan 17, 2025
1671eb4
Regenerate package-lock.
mkrause Jan 17, 2025
5670f19
Address comments.
mkrause Jan 17, 2025
aa36674
Refactor ModalDialogProvider -> TopLayerManager.
mkrause Jan 18, 2025
a03dbe4
Fix DialogOverlay animations.
mkrause Jan 19, 2025
135e016
Implement useOverlayWithSubject() hook.
mkrause Jan 20, 2025
03a213c
Make popover behavior configurable.
mkrause Jan 20, 2025
1e49af7
Remove comment.
mkrause Jan 20, 2025
b65d05c
Cleanup.
mkrause Jan 20, 2025
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion .storybook/preview.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,15 @@ import { addons } from '@storybook/preview-api';
import { DARK_MODE_EVENT_NAME, UPDATE_DARK_MODE_EVENT_NAME } from 'storybook-dark-mode';
import { DocsContainer, Title, Subtitle, Description, Primary, Controls, Stories } from '@storybook/blocks';

import { BaklavaProvider } from '../src/context/BaklavaProvider.tsx';


const channel = addons.getChannel();
const preview = {
decorators: [
Story => <BaklavaProvider><Story/></BaklavaProvider>,
],

parameters: {
options: {
storySort: {
Expand Down Expand Up @@ -65,10 +71,11 @@ const preview = {
'ModalProvider',
'SpinnerModal',
'DialogModal',
'DialogOverlay',
'ToastProvider',
'Tooltip',
'TooltipProvider',
'DropdownMenu',
'Toast',
],
'lists',
[
Expand Down
4 changes: 2 additions & 2 deletions app/lib.ts
Original file line number Diff line number Diff line change
Expand Up @@ -67,12 +67,12 @@ export { Tab, Tabs } from '../src/components/navigations/Tabs/Tabs.tsx';
export { ModalProvider } from '../src/components/overlays/ModalProvider/ModalProvider.tsx';
export { SpinnerModal } from '../src/components/overlays/SpinnerModal/SpinnerModal.tsx';
export { DialogModal } from '../src/components/overlays/DialogModal/DialogModal.tsx';
export { DialogOverlay } from '../src/components/overlays/DialogOverlay/DialogOverlay.tsx';
export { DropdownMenu } from '../src/components/overlays/DropdownMenu/DropdownMenu.tsx';
export { DropdownMenuProvider } from '../src/components/overlays/DropdownMenu/DropdownMenuProvider.tsx';
export { type ToastContent, ToastProvider, ToastMessage } from '../src/components/overlays/Toast/Toast.tsx';
export { ToastProvider, notify } from '../src/components/overlays/ToastProvider/ToastProvider.tsx';
export { Tooltip } from '../src/components/overlays/Tooltip/Tooltip.tsx';
export { TooltipProvider } from '../src/components/overlays/Tooltip/TooltipProvider.tsx';
export { notify } from '../src/components/overlays/Toast/Toast.tsx';

// Tables
export { useCustomFilters } from '../src/components/tables/DataTable/plugins/useCustomFilters.tsx';
Expand Down
6 changes: 4 additions & 2 deletions biome.jsonc
Original file line number Diff line number Diff line change
Expand Up @@ -24,16 +24,18 @@
"linter": {
"enabled": true,
"include": ["app/**/*", "src/**/*", "tests/**/*"],

"ignore": [
"node_modules",
"src/components/tables/MultiSearch/MultiSearch.tsx", // Ignore for now (need to focus on type errors first)
"tests/installation/**/*"
],
"rules": {
"recommended": true,
"complexity": {
"noBannedTypes": "off",
"noForEach": "off"
"noForEach": "off",
"useOptionalChain": "off"
},
"style": {
"useImportType": "off",
Expand Down
Loading
Loading